From c54fed69cd69f0a6b82d36a33ba286022a7aace6 Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Sun, 23 Aug 2020 03:31:14 +0530 Subject: [PATCH] Always use config to set default value of timeout in check version --- kafka/client_async.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kafka/client_async.py b/kafka/client_async.py index caa88cf5e..a5683507a 100644 --- a/kafka/client_async.py +++ b/kafka/client_async.py @@ -869,7 +869,7 @@ def get_api_versions(self): """ return self._api_versions - def check_version(self, node_id=None, timeout=2, strict=False): + def check_version(self, node_id=None, timeout=None, strict=False): """Attempt to guess the version of a Kafka broker. Note: It is possible that this method blocks longer than the @@ -885,6 +885,9 @@ def check_version(self, node_id=None, timeout=2, strict=False): UnrecognizedBrokerVersion: please file bug if seen! AssertionError (if strict=True): please file bug if seen! """ + if timeout is None: + timeout = self.config['api_version_auto_timeout_ms'] / 1000 + self._lock.acquire() end = time.time() + timeout while time.time() < end: