Skip to content

Commit 3ed1a9c

Browse files
Allow using non-row panels in dashboard's panels (#684)
As discussed in grafana/grafana#50855 (comment), panels of rows with collapsed=False should be added to the list of panels that contains that row. Adding non-row panels makes auto_panel_ids() fail with ``` File ".../grafanalib/core.py", line 1751, in auto_panel_ids ids = set([panel.id for panel in self._iter_panels() if panel.id]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../grafanalib/core.py", line 1731, in _iter_panels for row_panel in panel._iter_panels(): ^^^^^^^^^^^^^^^^^^ AttributeError: 'TimeSeries' object has no attribute '_iter_panels' ``` This change fixes this exception.
1 parent 5c3b17e commit 3ed1a9c

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

grafanalib/core.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1825,12 +1825,10 @@ def _iter_panels(self):
18251825
yield panel
18261826

18271827
for panel in self.panels:
1828-
if hasattr(panel, 'panels'):
1829-
yield panel
1828+
yield panel
1829+
if hasattr(panel, '_iter_panels'):
18301830
for row_panel in panel._iter_panels():
18311831
yield row_panel
1832-
else:
1833-
yield panel
18341832

18351833
def _map_panels(self, f):
18361834
return attr.evolve(

0 commit comments

Comments
 (0)