Skip to content

Commit 968fe75

Browse files
authored
Merge pull request #1505 from weaviate/chore/update-ci-images
Update Weaviate vers in CI to latest patches
2 parents d6ec7e7 + 1c91a10 commit 968fe75

File tree

5 files changed

+32
-17
lines changed

5 files changed

+32
-17
lines changed

.github/workflows/main.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,17 @@ on:
1313
- publishing.md
1414
pull_request:
1515

16+
concurrency:
17+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
18+
cancel-in-progress: true
19+
1620
env:
1721
WEAVIATE_124: 1.24.26
18-
WEAVIATE_125: 1.25.24
19-
WEAVIATE_126: 1.26.8
20-
WEAVIATE_127: 1.27.1
21-
WEAVIATE_128: preview-rbac-tenant-operation-permissions-be88593
22+
WEAVIATE_125: 1.25.29
23+
WEAVIATE_126: 1.26.13
24+
WEAVIATE_127: 1.27.9
25+
WEAVIATE_128: 1.28.2-2c00437
26+
2227
jobs:
2328
lint-and-format:
2429
name: Run Linter and Formatter

ci/docker-compose.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,12 @@ services:
2121
AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED: 'true'
2222
PERSISTENCE_DATA_PATH: '/var/lib/weaviate'
2323
DEFAULT_VECTORIZER_MODULE: 'text2vec-contextionary'
24-
ENABLE_MODULES: text2vec-contextionary,backup-filesystem,img2vec-neural,generative-dummy,generative-anyscale,reranker-dummy,reranker-cohere
24+
ENABLE_MODULES: text2vec-contextionary,backup-filesystem,generative-dummy,generative-anyscale,reranker-dummy,reranker-cohere
2525
BACKUP_FILESYSTEM_PATH: "/tmp/backups"
2626
CLUSTER_GOSSIP_BIND_PORT: "7100"
2727
CLUSTER_DATA_BIND_PORT: "7101"
2828
CLUSTER_HOSTNAME: "node1"
2929
AUTOSCHEMA_ENABLED: 'false'
30-
IMAGE_INFERENCE_API: "http://i2v-neural:8080"
3130
DISABLE_TELEMETRY: 'true'
3231
DISABLE_LAZY_LOAD_SHARDS: 'true'
3332
GRPC_MAX_MESSAGE_SIZE: 100000000 # 100mb
@@ -41,6 +40,4 @@ services:
4140
image: semitechnologies/contextionary:en0.16.0-v1.2.0
4241
ports:
4342
- 9999:9999
44-
i2v-neural:
45-
image: semitechnologies/img2vec-pytorch:resnet50
4643
...

integration/test_collection.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1276,6 +1276,9 @@ def test_near_text_offset(collection_factory: CollectionFactory) -> None:
12761276
assert objects[0].properties["value"] == "apple cake"
12771277

12781278

1279+
@pytest.mark.skip(
1280+
"img2vec-neural removed from CI. This test should go in the e2e-tests repo instead"
1281+
)
12791282
@pytest.mark.parametrize(
12801283
"image_maker",
12811284
[
@@ -1330,6 +1333,9 @@ def test_near_image(
13301333
assert objects3[0].uuid == uuid2
13311334

13321335

1336+
@pytest.mark.skip(
1337+
"img2vec-neural removed from CI. This test should go in the e2e-tests repo instead"
1338+
)
13331339
@pytest.mark.parametrize(
13341340
"image_maker",
13351341
[

integration/test_collection_aggregate.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -570,6 +570,9 @@ def test_near_text_missing_param(collection_factory: CollectionFactory) -> None:
570570
)
571571

572572

573+
@pytest.mark.skip(
574+
"img2vec-neural removed from CI. This test should go in the e2e-tests repo instead"
575+
)
573576
@pytest.mark.parametrize("option", [{"object_limit": 1}, {"certainty": 0.9}, {"distance": 0.1}])
574577
def test_near_image_aggregation(collection_factory: CollectionFactory, option: dict) -> None:
575578
collection = collection_factory(
@@ -591,6 +594,9 @@ def test_near_image_aggregation(collection_factory: CollectionFactory, option: d
591594
assert res.properties["rating"].maximum == 9
592595

593596

597+
@pytest.mark.skip(
598+
"img2vec-neural removed from CI. This test should go in the e2e-tests repo instead"
599+
)
594600
def test_near_image_missing_param(collection_factory: CollectionFactory) -> None:
595601
collection = collection_factory(
596602
properties=[

weaviate/rbac/models.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from pydantic import BaseModel
77

88
from weaviate.cluster.types import Verbosity
9+
from weaviate.util import _capitalize_first_letter
910

1011

1112
class PermissionData(TypedDict):
@@ -153,7 +154,7 @@ def _to_weaviate(self) -> WeaviatePermission:
153154
return {
154155
"action": self.action,
155156
"collections": {
156-
"collection": self.collection,
157+
"collection": _capitalize_first_letter(self.collection),
157158
"tenant": self.tenant,
158159
},
159160
}
@@ -167,7 +168,7 @@ def _to_weaviate(self) -> WeaviatePermission:
167168
return {
168169
"action": self.action,
169170
"tenants": {
170-
"collection": self.collection,
171+
"collection": _capitalize_first_letter(self.collection),
171172
"tenant": "*",
172173
},
173174
}
@@ -182,7 +183,7 @@ def _to_weaviate(self) -> WeaviatePermission:
182183
return {
183184
"action": self.action,
184185
"nodes": {
185-
"collection": self.collection,
186+
"collection": _capitalize_first_letter(self.collection),
186187
"verbosity": self.verbosity,
187188
},
188189
}
@@ -216,7 +217,7 @@ def _to_weaviate(self) -> WeaviatePermission:
216217
return {
217218
"action": self.action,
218219
"backups": {
219-
"collection": self.collection,
220+
"collection": _capitalize_first_letter(self.collection),
220221
},
221222
}
222223

@@ -240,7 +241,7 @@ def _to_weaviate(self) -> WeaviatePermission:
240241
return {
241242
"action": self.action,
242243
"data": {
243-
"collection": self.collection,
244+
"collection": _capitalize_first_letter(self.collection),
244245
"object": self.object_,
245246
"tenant": self.tenant,
246247
},
@@ -256,7 +257,7 @@ def _to_weaviate(self) -> WeaviatePermission:
256257
return {
257258
"action": self.action,
258259
"collections": {
259-
"collection": self.collection,
260+
"collection": _capitalize_first_letter(self.collection),
260261
"tenant": "*",
261262
},
262263
}
@@ -271,7 +272,7 @@ def _to_weaviate(self) -> WeaviatePermission:
271272
return {
272273
"action": self.action,
273274
"data": {
274-
"collection": self.collection,
275+
"collection": _capitalize_first_letter(self.collection),
275276
"object": "*",
276277
"tenant": "*",
277278
},
@@ -317,7 +318,7 @@ def _to_weaviate(self) -> WeaviatePermission:
317318
return {
318319
"action": self.action,
319320
"backups": {
320-
"collection": self.collection,
321+
"collection": _capitalize_first_letter(self.collection),
321322
},
322323
}
323324

@@ -332,7 +333,7 @@ def _to_weaviate(self) -> WeaviatePermission:
332333
return {
333334
"action": self.action,
334335
"nodes": {
335-
"collection": self.collection or "*",
336+
"collection": _capitalize_first_letter(self.collection or "*"),
336337
"verbosity": self.verbosity,
337338
},
338339
}

0 commit comments

Comments
 (0)