Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CK editor 5 #1001

Open
nhjohnstone opened this issue Jul 10, 2024 · 3 comments
Open

Switch to CK editor 5 #1001

nhjohnstone opened this issue Jul 10, 2024 · 3 comments
Assignees

Comments

@nhjohnstone
Copy link
Contributor

We need to update to CK editor 5 as CK editor 4 is deprecated

@nhjohnstone nhjohnstone self-assigned this Jul 10, 2024
Copy link

Branch nhjohnstone/issue-1001-switch-to-ck-editor-5 created!

@nhjohnstone
Copy link
Contributor Author

ran into some issues that are related to Drupal 10.3 update (or 10.2):

before switching to ckeditor 5, had to remove "class" and "start" from the tags in allowed html tags

Screenshot 2024-07-11 at 2 56 04 PM

https://www.drupal.org/project/drupal/issues/3410100

Linkit Media Library button is not working, due to a Drupal 10.3 change
https://www.drupal.org/project/drupal/issues/3446026

I added the patch so we could see the button, but we might want to remove it if this doesn't get fixed.
Linkit Media Library is not being maintained

@nhjohnstone
Copy link
Contributor Author

nhjohnstone commented Jul 11, 2024

testing process

ddev composer require web-illinois/illinois_framework_profile:dev-43-update-to-ckeditor5 -W

had to delete vendor folder and composer install to get patches to apply

there are no DB updates

enable ckeditor 5 in drupal UI

drush config-distro-update -y

imports the editor config changes

compile sass files

sass --watch scss/style.scss:css/style.css scss/ck5style.scss:css/ck5style.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant