Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: sourcemaps being generated after 1.0.1-rc.2 through 1.0.1 (latest) do not work with Sentry to decode stack traces #3433

Closed
canopus1io opened this issue Sep 10, 2024 · 10 comments · Fixed by #3596
Assignees
Labels
🐞 bug Something isn't working

Comments

@canopus1io
Copy link

canopus1io commented Sep 10, 2024

Version

  System:
    OS: Linux 6.1 Amazon Linux 2023
    CPU: (2) x64 Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
    Memory: 5.97 GB / 7.63 GB
    Container: Yes
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 127.0.6533.88
  npmPackages:
    @rsbuild/core: 1.0.1 => 1.0.1
    @rsbuild/plugin-css-minimizer: ^1.0.2 => 1.0.2
    @rsbuild/plugin-mdx: ^1.0.2 => 1.0.2
    @rsbuild/plugin-node-polyfill: ^1.0.4 => 1.0.4
    @rsbuild/plugin-react: 1.0.1 => 1.0.1



key versions:
@rsbuild/core@1.0.1
@rspack/core@1.03
@rspack/cli@1.03

@sentry/browser@8.29.0
@sentry/webpack-plugin@2.22.4

Details

Screenshot 2024-09-09 at 9 20 30 PM
image
stack traces do no resolve correctly

I first discovered this issue with:
@rsbuild/core@1.0.1-rc.5

I confirmed it works fine on:
@rsbuild/core@1.0.1-rc.2
image

Reproduce link

not yet available

Reproduce Steps

not yet available

@canopus1io canopus1io added the 🐞 bug Something isn't working label Sep 10, 2024
Copy link
Contributor

Hello @canopus1io. Please provide a reproduction repository or online demo. For background, see Why reproductions are required. Thanks ❤️

@chenjiahan
Copy link
Member

Maybe related to web-infra-dev/rspack#7647

Can you provide more information for debugging?

@SyMind
Copy link
Member

SyMind commented Sep 11, 2024

@canopus1io Can you check the correctness of the generated source map? Check where the source map is problematic.

@gitim
Copy link

gitim commented Sep 16, 2024

I have the same issue after web-infra-dev/rspack#7647. Source map genereated by rspack@1.0.0 is about ~28MB, by rspack@1.0.1 the source map is incomplete and only ~5MB.

@SyMind
Copy link
Member

SyMind commented Sep 18, 2024

@gitim Please provide the a demo to reproduce the issue.

@yuzhva
Copy link

yuzhva commented Sep 18, 2024

Hey hi, guys 👋

Would like to refer for this comment:
web-infra-dev/rspack#7914 (comment)

It seems that the issue is in optimization configurations.

Because when I'm disabling it or replacing SwcJsMinimizerRspackPlugin with TerserPlugin - the source-maps are generated properly.

Copy link
Contributor

As the issue was labelled with need reproduction, but no response in 5 days. This issue will be closed. Feel free to comment and reopen it if you have any further questions. For background, see Why reproductions are required.

由于该 issue 被标记为 "需要重现",但在 5 天内没有回应,因此该 issue 将被关闭。如果你有任何进一步的问题,请随时发表评论并重新打开该 issue。背景请参考 为什么需要最小重现

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
@chenjiahan chenjiahan reopened this Sep 24, 2024
@chenjiahan
Copy link
Member

@philippe-wm
Copy link

philippe-wm commented Sep 28, 2024

Potentially related: our project's sourcemaps are all incomplete. E.g. in every chunk, every files has only a few lines covered with sourcemaps, the rest of the lines having empty mappings.

Minification doesn't matter, but replacing SWC with Babel gives sourcemaps.

Unfortunately couldn't yet reproduce in a small project.

@chenjiahan
Copy link
Member

Should be fixed in the next release, see: web-infra-dev/rspack#7991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants