From 42b29f2d538f52358b77cae19d3f9f0546ded248 Mon Sep 17 00:00:00 2001 From: "reuben.dysarz" Date: Tue, 6 Aug 2024 14:42:58 -0300 Subject: [PATCH 1/3] :bug: textInput string to number --- src/Time/TimeInput.tsx | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/Time/TimeInput.tsx b/src/Time/TimeInput.tsx index 1531e91..c532e60 100644 --- a/src/Time/TimeInput.tsx +++ b/src/Time/TimeInput.tsx @@ -55,10 +55,10 @@ function TimeInput( setControlledValue(`${value}`) }, [value]) - const onInnerChange = (text: string) => { - setControlledValue(text) - if (text !== '' && text !== '0') { - onChanged(Number(text)) + const onInnerChange = (number: number) => { + setControlledValue(`${number}`) + if (number !== 0) { + onChanged(Number(number)) } } @@ -100,7 +100,10 @@ function TimeInput( onBlur={() => setInputFocused(false)} keyboardAppearance={theme.dark ? 'dark' : 'default'} keyboardType="number-pad" - onChangeText={onInnerChange} + onChangeText={(e: string) => { + onInnerChange(Number(e)); + } + } {...rest} /> {onPress && inputType === inputTypes.picker ? ( From 8a96ab3ac45f3c0d93f66dda08162d74597553cf Mon Sep 17 00:00:00 2001 From: "reuben.dysarz" Date: Wed, 7 Aug 2024 07:55:50 -0300 Subject: [PATCH 2/3] fix: lint --- src/Time/TimeInput.tsx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Time/TimeInput.tsx b/src/Time/TimeInput.tsx index c532e60..97314d9 100644 --- a/src/Time/TimeInput.tsx +++ b/src/Time/TimeInput.tsx @@ -101,9 +101,8 @@ function TimeInput( keyboardAppearance={theme.dark ? 'dark' : 'default'} keyboardType="number-pad" onChangeText={(e: string) => { - onInnerChange(Number(e)); - } - } + onInnerChange(Number(e)) + }} {...rest} /> {onPress && inputType === inputTypes.picker ? ( From b43163d449e84a946ef6b2286c4cd201e163e13b Mon Sep 17 00:00:00 2001 From: "reuben.dysarz" Date: Wed, 7 Aug 2024 08:26:23 -0300 Subject: [PATCH 3/3] adjust for better comparison --- src/Time/TimeInput.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Time/TimeInput.tsx b/src/Time/TimeInput.tsx index 97314d9..3aefe22 100644 --- a/src/Time/TimeInput.tsx +++ b/src/Time/TimeInput.tsx @@ -57,7 +57,7 @@ function TimeInput( const onInnerChange = (number: number) => { setControlledValue(`${number}`) - if (number !== 0) { + if (number >= 0) { onChanged(Number(number)) } }