Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icons (Ionicons) break calendar navigation icons (chevron left/right, menu up/down) #425

Closed
oussamakh96 opened this issue Sep 20, 2024 · 4 comments
Labels
bug Something isn't working needs more info Needs more information needs repro Needs reproducible example

Comments

@oussamakh96
Copy link

Hello everyone,

I'm using the icon parameter from react-native-paper to change the default icons to Ionicons like this:

`<PaperProvider
settings={{
icon: (props) => <Ionicons {...props} />,
}}
theme={AppTheme}

`
The icons work across the app, but in the react-native-paper-dates calendar component, the chevron icons for left/right navigation, and the menu up/down icons, are not functioning. They do not render correctly.

I would like to continue using Ionicons for the entire app but also need the calendar icons to work properly. Is there a way to customize the calendar icons or ensure that the navigation icons work with a custom icon set?

Thank you for your help!

@oussamakh96 oussamakh96 added the bug Something isn't working label Sep 20, 2024
@iM-GeeKy iM-GeeKy added needs more info Needs more information needs repro Needs reproducible example labels Sep 23, 2024
Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.).

Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

@RichardLindhout
Copy link
Member

Hey yeah I would make a component CustomIonicIcon and log which items are used for icons. Then return their IonicIcon variant

@oussamakh96
Copy link
Author

Thanks for your response @RichardLindhout Waiting for new pull 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info Needs more information needs repro Needs reproducible example
Projects
None yet
Development

No branches or pull requests

3 participants