-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Takes a while to load dates #67
Comments
Interesting will be a nice case to improve performance since as far as I know I have tried almost every optimisation possible. Maybe we can indeed render less on low-end devices but we need to at least render 3 months because it will be too much white when scrolling else. |
@RichardLindhout how about rendering the current month in the first render and then render the other 3 right after? I think we could try to wrap a function responsible for rendering the other 3 months with |
@brunohkbx hm that is interesting but in my case I was not loading multiple months as it still load when I change to next month |
I think the rendering needs to te be faster as this will bite back when we scroll down |
Let's rewrite it in Flutter :-P |
Maybe we could detect the performance of the device and edit the amount of months loaded, because I also want fast scrolling so maybe it's a good idea to only 1 month on smaller screens |
Indeed we should not need to load 4 months at once, it also seems like the all 4 month are re-rendered when user scrolls while only new ones should reload |
I've improved some things in v0.4.5, I would also recommend using Hermes on Android. |
I am using Expo with Hermes (and polyfills) and still seeing very slow loading performance 🤷 |
Is it only on my end, ,or does this continue to be an issue? |
Well still an issue for me.. |
I think we could optimize using the native view / text directly. See callstack/react-native-paper#4157 cc: @iM-GeeKy |
Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.). |
Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it. |
I am using hermes and polyfill, at first I was using another locale but I changed it back to en but it doesn't seem to fix it. I also thought that it might be the emulator but I have tried on real devices and the problem is still there
The text was updated successfully, but these errors were encountered: