Skip to content

Commit 781ab49

Browse files
authored
Merge pull request #854 from udarrr/main
deleted internet explorer and old edge from default config
2 parents dd50a6f + 54bf574 commit 781ab49

File tree

3 files changed

+3
-78
lines changed

3 files changed

+3
-78
lines changed

lib/default-config.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,13 @@ module.exports = () => {
1010
onlyDriverArgs: [],
1111
baseURL: 'https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing',
1212
},
13-
ie: {
14-
version: '3.150.1',
15-
arch: process.arch,
16-
baseURL: 'https://selenium-release.storage.googleapis.com',
17-
},
1813
firefox: {
1914
version: 'latest',
2015
fallbackVersion: '0.30.0',
2116
arch: process.arch,
2217
onlyDriverArgs: [],
2318
baseURL: 'https://github.com/mozilla/geckodriver/releases/download',
2419
},
25-
edge: {
26-
version: '17134',
27-
},
2820
chromiumedge: {
2921
version: 'latest',
3022
fallbackVersion: '117.0.2045.55',

test/cli-parameters.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,16 @@ describe('`selenium-standalone` command parameters', () => {
137137
process.argv = buildArgv([
138138
'install',
139139
'--config=' + path.join(__dirname, 'fixtures', 'config.valid.js'),
140-
'--drivers.ie.version=43',
140+
'--drivers.chrome.version=43',
141141
'--',
142142
'--some=seleniumArgs',
143143
]);
144144

145145
const parsed = parseCommandAndOptions('/somewhere');
146146

147147
expect(parsed[1].version).to.be.equal('42');
148-
expect(parsed[1].drivers.ie.arch).to.be.equal(defaultValues.drivers.ie.arch);
149-
expect(parsed[1].drivers.ie.version).to.be.equal('43');
148+
expect(parsed[1].drivers.chrome.arch).to.be.equal(defaultValues.drivers.chrome.arch);
149+
expect(parsed[1].drivers.chrome.version).to.be.equal('43');
150150
expect(parsed[1].seleniumArgs).to.be.deep.equal(['--some=seleniumArgs']);
151151
});
152152

test/default-downloads-test.js

Lines changed: 0 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -56,73 +56,6 @@ describe('default-downloads', function () {
5656
});
5757
});
5858

59-
if (process.version.startsWith('v14.')) {
60-
describe('ie', () => {
61-
before(() => {
62-
Object.defineProperty(process, 'platform', {
63-
value: 'win32',
64-
});
65-
});
66-
67-
it('ia32 download exists', async () => {
68-
opts = merge(opts, {
69-
drivers: {
70-
ie: {
71-
arch: 'ia32',
72-
},
73-
},
74-
});
75-
76-
computedUrls = await computeDownloadUrls(opts);
77-
78-
assert(computedUrls.ie.indexOf('Win32') > 0);
79-
await doesDownloadExist(computedUrls.ie);
80-
});
81-
82-
it('x64 download exists', async () => {
83-
opts = merge(opts, {
84-
drivers: {
85-
ie: {
86-
arch: 'x64',
87-
},
88-
},
89-
});
90-
91-
computedUrls = await computeDownloadUrls(opts);
92-
93-
assert(computedUrls.ie.indexOf('x64') > 0);
94-
await doesDownloadExist(computedUrls.ie);
95-
});
96-
});
97-
98-
describe('edge', () => {
99-
before(() => {
100-
Object.defineProperty(process, 'platform', {
101-
value: 'win32',
102-
});
103-
});
104-
105-
const releases = require('../lib/microsoft-edge-releases');
106-
107-
Object.keys(releases).forEach((version) => {
108-
it('version `' + version + '` download exists', async () => {
109-
opts = merge(opts, {
110-
drivers: {
111-
edge: {
112-
version: version,
113-
},
114-
},
115-
});
116-
117-
computedUrls = await computeDownloadUrls(opts);
118-
119-
assert.strictEqual(computedUrls.edge, releases[version].url);
120-
await doesDownloadExist(computedUrls.edge);
121-
});
122-
});
123-
});
124-
}
125-
12659
describe('chrome', () => {
12760
describe('linux', () => {
12861
before(() => {

0 commit comments

Comments
 (0)