Skip to content

Commit 93a3d4f

Browse files
authored
(#589) Get fallback version if bundle is not available for wanted platform (#595)
* get fallback version if bundle is not available for wanted platform Meant to fix #589 * Linting compute-download-urls.js
1 parent 2cc1557 commit 93a3d4f

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

lib/compute-download-urls.js

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,21 @@ function getChromiumEdgeDriverArchitecture(wantedArchitecture) {
191191
return platform;
192192
}
193193

194+
async function chromiumEdgeBundleAvailable(opts) {
195+
const url = util.format(
196+
urls.chromiumedge,
197+
opts.drivers.chromiumedge.baseURL,
198+
opts.drivers.chromiumedge.version,
199+
getChromiumEdgeDriverArchitecture(opts.drivers.chromiumedge.platform)
200+
);
201+
try {
202+
await got.head(url, { timeout: 10000 });
203+
} catch (_) {
204+
return false;
205+
}
206+
return true;
207+
}
208+
194209
async function resolveLatestVersion(opts, browserDriver, url) {
195210
if (opts.drivers[browserDriver].version === 'latest') {
196211
try {
@@ -202,11 +217,10 @@ async function resolveLatestVersion(opts, browserDriver, url) {
202217
* it seems that linux releases are not for every version
203218
*/
204219
} else if (browserDriver === 'chromiumedge') {
205-
if (
206-
getChromiumEdgeDriverArchitecture(opts.drivers.chromiumedge.arch) !== 'linux64' &&
207-
(await getLatestChromium(opts, browserDriver, url))
208-
) {
209-
return true;
220+
if (await getLatestChromium(opts, browserDriver, url)) {
221+
if (await chromiumEdgeBundleAvailable(opts)) {
222+
return true;
223+
}
210224
}
211225
} else if (await getLatestChromium(opts, browserDriver, url)) {
212226
return true;

lib/default-config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module.exports = () => {
2525
},
2626
chromiumedge: {
2727
version: 'latest',
28-
fallbackVersion: '94.0.992.9',
28+
fallbackVersion: '96.0.1054.34',
2929
arch: process.arch,
3030
baseURL: 'https://msedgedriver.azureedge.net',
3131
},

0 commit comments

Comments
 (0)