Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment with Protractors Expected Conditions #2

Closed
christian-bromann opened this issue Apr 20, 2021 · 4 comments
Closed

Alignment with Protractors Expected Conditions #2

christian-bromann opened this issue Apr 20, 2021 · 4 comments

Comments

@christian-bromann
Copy link
Member

Hey,

how about aligning some of the expected conditions with the ones Protractor has. One reason for that is that Protractor is being discontinued and it would help a lot of users that make the transition to WebdriverIO to just swap in this service and keep their tests as is. I then could update the codemod to notify users to use this service. That would be a nice drop in replacement.

What do you think?

@elaichenkov
Copy link
Member

Hey again!

Yep, I thought about that but decided to name some methods more meaningful than protractor's conditions. But, totally agree with you, that could help a ton of users to make migration easier.

I'll align them.

@christian-bromann
Copy link
Member Author

@elaichenkov I don't mind keeping the current ones as they are. Maybe there can just be an alias.

@elaichenkov
Copy link
Member

Done.

Now, in the 2.0.2 version, all methods are aligned with the protractor's methods.

@christian-bromann
Copy link
Member Author

That's amazing, great work! I will get the codemod updated within the next days. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants