Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the shortcodes filter use is_safe => 'html'? #19

Open
mpdude opened this issue May 27, 2022 · 0 comments
Open

Should the shortcodes filter use is_safe => 'html'? #19

mpdude opened this issue May 27, 2022 · 0 comments

Comments

@mpdude
Copy link
Member

mpdude commented May 27, 2022

The shortcodes Twig filter currently declares is_safe => 'html'. That means that whatever content is passed through it will have further output escaping disabled.

Although I understand why it was tempting to implement it that way, I am not sure if that is really in the best interest of our users?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpdude