Fix some errors on feed generation

Author: lruozzi9

src/DataSyncInfrastructure/Generator/ResourceFeedGenerator.php

@@ -39,15 +39,19 @@ public function generate(
 
         $payload = [];
         foreach ($resources as $resource) {
-            $payload[] = $this->serializer->normalize(
-                $resource,
-                'array',
-                [
-                    'type' => 'webgriffe_sylius_clerk_plugin',
-                    'channel' => $channel,
-                    'localeCode' => $localeCode,
-                ],
-            );
+            try {
+                $payload[] = $this->serializer->normalize(
+                    $resource,
+                    'array',
+                    [
+                        'type' => 'webgriffe_sylius_clerk_plugin',
+                        'channel' => $channel,
+                        'localeCode' => $localeCode,
+                    ],
+                );
+            } catch (\Throwable $e) {
+                continue;
+            }
         }
 
         return new Feed(

src/DataSyncInfrastructure/Normalizer/Event/ProductNormalizerEvent.php

@@ -13,10 +13,10 @@ final class ProductNormalizerEvent
      * @param array{
      *      id: string|int,
      *      name: string,
-     *      description: string,
+     *      description?: string,
      *      price: float,
      *      list_price: float,
-     *      image: string,
+     *      image?: string,
      *      url: string,
      *      categories: array<int|string>,
      *      created_at: string,
@@ -40,10 +40,10 @@ public function __construct(
      * @return array{
      *      id: string|int,
      *      name: string,
-     *      description: string,
+     *      description?: string,
      *      price: float,
      *      list_price: float,
-     *      image: string,
+     *      image?: string,
      *      url: string,
      *      categories: array<int|string>,
      *      created_at: string,
@@ -63,10 +63,10 @@ public function getProductData(): array
      * @param array{
      *      id: string|int,
      *      name: string,
-     *      description: string,
+     *      description?: string,
      *      price: float,
      *      list_price: float,
-     *      image: string,
+     *      image?: string,
      *      url: string,
      *      categories: array<int|string>,
      *      created_at: string,

src/DataSyncInfrastructure/Normalizer/ProductNormalizer.php

@@ -37,10 +37,10 @@ public function __construct(
      * @return array{
      *     id: string|int,
      *     name: string,
-     *     description: string,
+     *     description?: string,
      *     price: float,
      *     list_price: float,
-     *     image: string,
+     *     image?: string,
      *     url: string,
      *     categories: array<int|string>,
      *     created_at: string,
@@ -72,9 +72,6 @@ public function normalize(mixed $object, ?string $format = null, array $context
             throw new \InvalidArgumentException('Product name must not be null for the product "' . $productId . '".');
         }
         $productDescription = $productTranslation->getDescription();
-        if ($productDescription === null) {
-            throw new \InvalidArgumentException('Product description must not be null for the product "' . $productId . '".');
-        }
         $productVariant = $this->productVariantResolver->getVariant($product);
         if (!$productVariant instanceof ProductVariantInterface) {
             throw new \InvalidArgumentException('At least one product variant should exists for the product "' . $productId . '".');
@@ -83,7 +80,10 @@ public function normalize(mixed $object, ?string $format = null, array $context
         $originalPrice = $this->productVariantPricesCalculator->calculateOriginal($productVariant, ['channel' => $channel]);
 
         $productMainImage = $this->getMainImage($product);
-        $productMainImageUrl = $this->getUrlOfImage($productMainImage, $channel);
+        $productMainImageUrl = null;
+        if ($productMainImage !== null) {
+            $productMainImageUrl = $this->getUrlOfImage($productMainImage, $channel);
+        }
         $productUrl = $this->getUrlOfProduct($productTranslation, $channel);
         $createdAt = $product->getCreatedAt();
         if ($createdAt === null) {
@@ -93,14 +93,18 @@ public function normalize(mixed $object, ?string $format = null, array $context
         $productData = [
             'id' => $productId,
             'name' => $productName,
-            'description' => $productDescription,
             'price' => $price / 100,
             'list_price' => $originalPrice / 100,
-            'image' => $productMainImageUrl,
             'url' => $productUrl,
             'categories' => $this->getCategoryIds($product),
             'created_at' => $createdAt->format('c'),
         ];
+        if ($productDescription !== null) {
+            $productData['description'] = $productDescription;
+        }
+        if ($productMainImageUrl !== null) {
+            $productData['image'] = $productMainImageUrl;
+        }
 
         $productNormalizerEvent = new ProductNormalizerEvent(
             $productData,
@@ -123,19 +127,18 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
         ;
     }
 
-    public function getMainImage(ProductInterface $product): ProductImageInterface
+    public function getMainImage(ProductInterface $product): ?ProductImageInterface
     {
         $imageByType = $product->getImagesByType($this->imageType)->first();
         if ($imageByType instanceof ProductImageInterface) {
             return $imageByType;
         }
-
         $image = $product->getImages()->first();
         if ($image instanceof ProductImageInterface) {
             return $image;
         }
 
-        throw new \InvalidArgumentException('Product "' . (string) $product->getId() . '" has no images.');
+        return null;
     }
 
     public function getUrlOfImage(ProductImageInterface $productMainImage, ChannelInterface $channel): string
@@ -146,8 +149,11 @@ public function getUrlOfImage(ProductImageInterface $productMainImage, ChannelIn
         Assert::stringNotEmpty($channelHost);
         $channelRequestContext->setHost($channelHost);
 
+        $imagePath = $productMainImage->getPath();
+        Assert::stringNotEmpty($imagePath, 'Product image path must not be empty.');
+
         $imageUrl = $this->cacheManager->getBrowserPath(
-            (string) $productMainImage->getPath(),
+            $imagePath,
             $this->imageFilterToApply,
         );