fix tests

Author: shmax

tests/Executor/ValidationWithCacheTest.php

@@ -5,6 +5,7 @@
 use DMS\PHPUnitExtensions\ArraySubset\ArraySubsetAsserts;
 use GraphQL\Deferred;
 use GraphQL\GraphQL;
+use GraphQL\Language\AST\DocumentNode;
 use GraphQL\Tests\Executor\TestClasses\Cat;
 use GraphQL\Tests\Executor\TestClasses\Dog;
 use GraphQL\Tests\PsrValidationCacheAdapter;
@@ -16,13 +17,32 @@
 use Symfony\Component\Cache\Adapter\ArrayAdapter;
 use Symfony\Component\Cache\Psr16Cache;
 
+final class SpyValidationCacheAdapter extends PsrValidationCacheAdapter
+{
+    public int $isValidatedCalls = 0;
+    public int $markValidatedCalls = 0;
+
+    public function isValidated(Schema $schema, DocumentNode $ast): bool
+    {
+        $this->isValidatedCalls++;
+        return parent::isValidated($schema, $ast);
+    }
+
+    public function markValidated(Schema $schema, DocumentNode $ast): void
+    {
+        $this->markValidatedCalls++;
+        parent::markValidated($schema, $ast);
+    }
+}
+
+
 final class ValidationWithCacheTest extends TestCase
 {
     use ArraySubsetAsserts;
 
     public function testIsValidationCachedWithAdapter(): void
     {
-        $cache = new PsrValidationCacheAdapter(new Psr16Cache(new ArrayAdapter()));
+        $cache = new SpyValidationCacheAdapter(new Psr16Cache(new ArrayAdapter()));
         $petType = new InterfaceType([
             'name' => 'Pet',
             'fields' => [
@@ -78,11 +98,14 @@ public function testIsValidationCachedWithAdapter(): void
           }
         }';
 
+        // make the same call twice in a row. We'll then inspect the cache object to count calls
         GraphQL::executeQuery( $schema, $query, null, null, null, null, null, null, $cache)->toArray();
-
-        // TODO: use a spy or something to prove that the validation only happens once
         $result = GraphQL::executeQuery( $schema, $query, null, null, null, null, null, null, $cache)->toArray();
 
+        // ✅ Assert that validation only happened once
+        self::assertEquals(2, $cache->isValidatedCalls, 'Should check cache twice');
+        self::assertEquals(1, $cache->markValidatedCalls, 'Should mark as validated once');
+
         $expected = [
             'data' => [
                 'pets' => [

tests/PsrValidationCacheAdapter.php

@@ -9,7 +9,7 @@
 use Psr\SimpleCache\CacheInterface;
 use Symfony\Component\String\Exception\InvalidArgumentException;
 
-final class PsrValidationCacheAdapter implements ValidationCache
+class PsrValidationCacheAdapter implements ValidationCache
 {
     private const KEY_PREFIX = 'gql_validation_';
     private int $ttl;