Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Ensure pages for uploads are indexed as seeds #2389

Closed
ikreymer opened this issue Feb 13, 2025 · 0 comments · Fixed by #2390
Closed

[Feature]: Ensure pages for uploads are indexed as seeds #2389

ikreymer opened this issue Feb 13, 2025 · 0 comments · Fixed by #2390
Assignees
Labels
enhancement New feature or request

Comments

@ikreymer
Copy link
Member

What change would you like to see?

When pages from uploads are indexed, they should be marked as seeds if:

  • seed flag is set in the page json
  • if the pages comes from pages.jsonl, but not extraPages.jsonl

This way, existing uploads from ArchiveWeb.page will have their pages marked as seeds, and will appear in the list. Crawls uploaded from a different Browsertrix / Browsertrix Crawler will also have pages indexed correctly, as they should have the seed flag set already and using pages.jsonl / extraPages.jsonl

Context

Ensure uploads appear correctly in collections with the new collection loading optimizations.

@ikreymer ikreymer added the enhancement New feature or request label Feb 13, 2025
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Feb 13, 2025
@ikreymer ikreymer added this to the Public Collections milestone Feb 13, 2025
@tw4l tw4l moved this from Todo to Implementing in Webrecorder Projects Feb 13, 2025
@tw4l tw4l moved this from Implementing to In Review in Webrecorder Projects Feb 13, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants