Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Page list not loading in QA review screen #2434

Closed
tw4l opened this issue Feb 27, 2025 · 0 comments · Fixed by #2435
Closed

[Bug]: Page list not loading in QA review screen #2434

tw4l opened this issue Feb 27, 2025 · 0 comments · Fixed by #2435
Assignees
Labels
bug Something isn't working

Comments

@tw4l
Copy link
Member

tw4l commented Feb 27, 2025

Browsertrix Version

v1.4.1

What did you expect to happen? What happened instead?

Page lists are not loading in QA in Browsertrix 1.4.0 and 1.4.1 due to total in the QA pages endpoint always being set to 0.

To fix this, we should include include_total=True in the list_pages call for that endpoint.

Reproduction instructions

  1. Navigate to Review screen for a crawl that has had an analysis run
  2. Verify pages do not load in screen
  3. Open network tab, verify that pages are being returned but total is 0

Screenshots / Video

No response

Environment

No response

Additional details

No response

@tw4l tw4l added the bug Something isn't working label Feb 27, 2025
@tw4l tw4l moved this from Triage to Implementing in Webrecorder Projects Feb 27, 2025
@tw4l tw4l self-assigned this Feb 27, 2025
@ikreymer ikreymer moved this from Implementing to Todo in Webrecorder Projects Feb 27, 2025
@tw4l tw4l moved this from Todo to In Review in Webrecorder Projects Feb 27, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

1 participant