Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: replay.json for empty collection returns 400 #2443

Closed
ikreymer opened this issue Mar 1, 2025 · 0 comments · Fixed by #2445
Closed

[Bug]: replay.json for empty collection returns 400 #2443

ikreymer opened this issue Mar 1, 2025 · 0 comments · Fixed by #2445
Assignees
@ikreymer
Labels
bug Something isn't working

Comments

@ikreymer
Copy link
Member

ikreymer commented Mar 1, 2025

Browsertrix Version

v1.14.2

What did you expect to happen? What happened instead?

Should not be an error.

Reproduction instructions

  1. Create empty collection.
  2. Load collection, observe 'Something went wrong message"

Screenshots / Video

No response

Environment

No response

Additional details

No response
@ikreymer ikreymer added the bug Something isn't working label Mar 1, 2025
@ikreymer ikreymer self-assigned this Mar 1, 2025
@ikreymer ikreymer moved this from Triage to Implementing in Webrecorder Projects Mar 1, 2025
@ikreymer ikreymer moved this from Implementing to Todo in Webrecorder Projects Mar 1, 2025
ikreymer added a commit that referenced this issue Mar 1, 2025
@ikreymer
make list_pages() return empty response if no crawls provided, instea…
ca9cd07 
…d of throwing

tests: add tests for empty collection
fixes #2443
@ikreymer ikreymer mentioned this issue Mar 1, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done! in Webrecorder Projects Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

Labels
bug Something isn't working
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix replay.json 400 response for empty collection webrecorder/browsertrix
1 participant
@ikreymer