Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly interop CI failures #1692

Open
fippo opened this issue Dec 31, 2024 · 7 comments · Fixed by #1694
Open

Nightly interop CI failures #1692

fippo opened this issue Dec 31, 2024 · 7 comments · Fixed by #1694
Assignees
Labels

Comments

@fippo
Copy link
Collaborator

fippo commented Dec 31, 2024

https://github.com/webrtc/samples/actions has been failing the interop tests pretty consistently.
However, cloning the exact same code into a private repo I have works without any issues.

@fippo fippo added the interop label Dec 31, 2024
@fippo fippo self-assigned this Dec 31, 2024
fippo added a commit to fippo/webrtc that referenced this issue Jan 3, 2025
fippo added a commit to fippo/webrtc that referenced this issue Jan 3, 2025
@fippo
Copy link
Collaborator Author

fippo commented Jan 3, 2025

fippo/samples-ci-debug#1 -- same code works without errors there...

@fippo
Copy link
Collaborator Author

fippo commented Jan 3, 2025

aha, a possible difference: in this repo Ubuntu 24.04.1 LTS is used while in the other repo it is still 22.04.5

@fippo
Copy link
Collaborator Author

fippo commented Jan 3, 2025

actions/runner-images#10636 -- 24.04 rollout started on December 5th which roughly correlates with the failures starting to happen on December 8th. Lets pin to 22.04 to unbreak the tests

@alvestrand
Copy link
Contributor

May explain another issue I saw with a PR test failing.
I can't remember seeing a notification of the failure. Who gets notified on such failures?

@fippo fippo reopened this Jan 3, 2025
@fippo
Copy link
Collaborator Author

fippo commented Jan 3, 2025

Still needs some investigation about why it fails on 24.04 - most likely changed chromedriver/geckodriver path

@fippo
Copy link
Collaborator Author

fippo commented Jan 3, 2025

May explain another issue I saw with a PR test failing. I can't remember seeing a notification of the failure. Who gets notified on such failures?

If I read
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/monitoring-workflows/notifications-for-workflow-runs
correctly those failures will go to me (well, I filter them) you might have to make a commit with the webrtc-dev@ email...

@fippo
Copy link
Collaborator Author

fippo commented Jan 6, 2025

Some progress:

  • mapVersion is missing the "browser" argument. Oops.
  • Chrome fails to start. I can reproduce this locally when using BROWSER_A=chrome BROWSER_B=firefox BVER=unstable DISPLAY=:99.0 node test/download-browsers.js without running Xvfb. This suggests the issue with related to xvfb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants