Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ubuntu version to 22.04 LTS #1694

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

fippo
Copy link
Collaborator

@fippo fippo commented Jan 3, 2025

fixes #1692 (well, works around)

@fippo fippo force-pushed the fix-nightly-tests branch from 993464b to 4655e2a Compare January 3, 2025 19:09
@fippo fippo marked this pull request as draft January 3, 2025 19:17
@fippo fippo force-pushed the fix-nightly-tests branch from 6bc10a3 to 3375453 Compare January 3, 2025 19:18
@fippo fippo force-pushed the fix-nightly-tests branch from 3375453 to 2dcdb64 Compare January 3, 2025 19:40
@fippo fippo changed the title Debug nightly tests Pin ubuntu version to 22.04 LTS Jan 3, 2025
@fippo fippo requested a review from alvestrand January 3, 2025 20:39
@fippo fippo marked this pull request as ready for review January 3, 2025 20:39
@fippo
Copy link
Collaborator Author

fippo commented Jan 3, 2025

Note: the test fails since it still uses 24.04 and does not pick up the change in .github:
image
https://github.com/webrtc/samples/actions/runs/12603003803/job/35127177681?pr=1694#step:1:1
so we will need to merge and then 🤞

@alvestrand alvestrand merged commit 77afad9 into webrtc:gh-pages Jan 3, 2025
2 of 3 checks passed
fippo added a commit to fippo/webrtc that referenced this pull request Jan 4, 2025
follow-up to webrtc#1694 which only replaced the wrong (first) test runner
Use ubuntu-latest for lint
alvestrand pushed a commit that referenced this pull request Jan 4, 2025
follow-up to #1694 which only replaced the wrong (first) test runner
Use ubuntu-latest for lint
@fippo fippo deleted the fix-nightly-tests branch January 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly interop CI failures
2 participants