Fix rows reorder when pagination is applied. #6973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the pagination is activated and the rows are reordered on pages other than the first one, the order was not taking into account the page number and the page size. This commit changes the index at which the row needs to be inserted by accounting for the page size and page number.
wenzhixin
reviewed
Sep 24, 2023
wenzhixin
reviewed
Sep 24, 2023
|
Please provide an Online Example to show your problem. Thanks! |
|
@wenzhixin Please see https://examples.bootstrap-table.com/#extensions/reorder-rows.html |
Co-authored-by: 文翼 <wenzhixin2010@gmail.com>
Co-authored-by: 文翼 <wenzhixin2010@gmail.com>
|
This is an example using you're commit: https://live.bootstrap-table.com/code/UtechtDustin/16248 |
|
@UtechtDustin I have fixed the redeclaration issue in the previous commit, please try to run again. I am not able to load the updated code in the live editor though. |
UtechtDustin
approved these changes
Oct 1, 2023
|
Thank you for the contibution, the latest commit is in the cache of the used cdn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the pagination is activated and the rows are reordered on pages other than the first one, the order was not taking into account the page number and the page size. This commit changes the index at which the row needs to be inserted by accounting for the page size and page number.
🤔Type of Request
📝Changelog