Fix rubocop offenses

Author: weppos

bin/whoisrb

@@ -47,7 +47,7 @@ OptionParser.new do |opts|
     exit 1
   end
 
-  if ARGV.size.zero?
+  if ARGV.empty?
     puts opts
     exit 1
   end

lib/whois.rb

@@ -44,7 +44,7 @@ def lookup(object)
     def available?(object)
       unless defined? Whois::Parser
         warn("Whois.available? requires the gem `whois-parser`")
-        return
+        return false
       end
 
       deprecate(%{Whois.available? is deprecated. Call Whois.whois("#{object}").parser.available?})
@@ -61,7 +61,7 @@ def available?(object)
     def registered?(object)
       unless defined? Whois::Parser
         warn("Whois.registered? requires the gem `whois-parser`")
-        return
+        return false
       end
 
       deprecate(%{Whois.registered? is deprecated. Call Whois.whois("#{object}").parser.registered?})
@@ -90,8 +90,8 @@ def deprecate(message = nil, callstack = caller)
     # @private
     def bug!(error, message)
       raise error, message.dup <<
-                   " Please report the issue at" \
-                   " http://github.com/weppos/whois/issues"
+                   " Please report the issue at " \
+                   "http://github.com/weppos/whois/issues"
     end
 
 

lib/whois/record/part.rb

@@ -26,7 +26,7 @@ class Record
       def initialize(*args)
         if args.first.is_a? Hash
           initialize_with_hash(args.first)
-        elsif args.size.zero?
+        elsif args.empty?
           super
         else
           raise ArgumentError

lib/whois/server/adapters/arin.rb

@@ -44,7 +44,7 @@ def extract_referral(response)
 
           {
             host: Regexp.last_match(1),
-            port: Regexp.last_match(2) ? Regexp.last_match(2).to_i : nil,
+            port: Regexp.last_match(2)&.to_i,
           }
         end
 

spec/whois/record_spec.rb

@@ -138,8 +138,8 @@
 
   describe "#match?" do
     it "calls match and checks for match" do
-      expect(subject.match?(/record/)).to eq(true)
-      expect(subject.match?(/nomatch/)).to eq(false)
+      expect(subject.match?(/record/)).to be(true)
+      expect(subject.match?(/nomatch/)).to be(false)
     end
   end