fix "devices not support this instance" error message

This was actually harmless, but noisy.  The cause was that Govee
API returns this error message when trying to list the available
scenes for the device. When I started this project the API returned
an empty list, but as of a few days ago they made it return an
error condition for devices that don't support scenes. We ignore
the error and continue, so it didn't harm anything, it was
just noisy.

refs: #58
refs: #50
refs: #59
refs: #56

Author: wez

src/platform_api.rs

@@ -147,6 +147,10 @@ impl GoveeApiClient {
         &self,
         device: &HttpDeviceInfo,
     ) -> anyhow::Result<Vec<DeviceCapability>> {
+        if !device.supports_dynamic_scenes() {
+            return Ok(vec![]);
+        }
+
         let key = format!("scene-list-diy-{}-{}", device.sku, device.device);
         cache_get(
             CacheGetOptions {
@@ -181,6 +185,10 @@ impl GoveeApiClient {
         &self,
         device: &HttpDeviceInfo,
     ) -> anyhow::Result<Vec<DeviceCapability>> {
+        if !device.supports_dynamic_scenes() {
+            return Ok(vec![]);
+        }
+
         let key = format!("scene-list-{}-{}", device.sku, device.device);
         cache_get(
             CacheGetOptions {
@@ -635,6 +643,13 @@ impl HttpDeviceInfo {
         self.capability_by_instance("brightness").is_some()
     }
 
+    pub fn supports_dynamic_scenes(&self) -> bool {
+        self
+            .capabilities
+            .iter()
+            .any(|cap| cap.kind == DeviceCapabilityKind::DynamicScene)
+    }
+
     /// If supported, returns the number of segments
     pub fn supports_segmented_rgb(&self) -> Option<std::ops::Range<u32>> {
         let cap = self.capability_by_instance("segmentedColorRgb")?;

src/service/quirks.rs

@@ -14,7 +14,6 @@ pub struct Quirk {
     pub ble_only: bool,
     pub lan_api_capable: bool,
     pub device_type: DeviceType,
-    pub supports_scenes: Option<bool>,
 }
 
 impl Quirk {
@@ -29,7 +28,6 @@ impl Quirk {
             icon: icon.into(),
             lan_api_capable: false,
             device_type: DeviceType::Light,
-            supports_scenes: None,
         }
     }
 
@@ -44,15 +42,9 @@ impl Quirk {
             icon: "mdi:air-humidifier".into(),
             lan_api_capable: false,
             device_type: DeviceType::Humidifier,
-            supports_scenes: None,
         }
     }
 
-    pub fn with_scenes(mut self, supports_scenes: Option<bool>) -> Self {
-        self.supports_scenes = supports_scenes;
-        self
-    }
-
     pub fn with_rgb(mut self) -> Self {
         self.supports_rgb = true;
         self
@@ -119,7 +111,6 @@ fn load_quirks() -> HashMap<String, Quirk> {
         Quirk::humidifier("H7160")
             .with_broken_platform()
             .with_rgb()
-            .with_scenes(Some(false))
             .with_brightness(),
         // Lights from the list of LAN API enabled devices
         // at <https://app-h5.govee.com/user-manual/wlan-guide>

src/service/state.rs

@@ -488,13 +488,6 @@ impl State {
 
     pub async fn device_list_scenes(&self, device: &Device) -> anyhow::Result<Vec<String>> {
         // TODO: some plumbing to maintain offline scene controls for preferred-LAN control
-
-        if let Some(quirk) = device.resolve_quirk() {
-            if quirk.supports_scenes == Some(false) {
-                return Ok(vec![]);
-            }
-        }
-
         if let Some(client) = self.get_platform_client().await {
             if let Some(info) = &device.http_device_info {
                 return Ok(sort_and_dedup_scenes(client.list_scene_names(info).await?));