Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure plate calculator #46

Open
rolandgeider opened this issue Jun 20, 2021 · 27 comments
Open

Configure plate calculator #46

rolandgeider opened this issue Jun 20, 2021 · 27 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@rolandgeider
Copy link
Member

rolandgeider commented Jun 20, 2021

Use case

Allow to configure the available plates for the calculator

Proposal

At the moment, the plate calculator uses a bar weight of 20 (kg) and a hard coded list of available plates (1.25, 2.5, 5, 10, 15). This list should be configurable, as not all gyms have all plates (plus lb - kg differences). I'm thinking about making a new Provider for this?

@rolandgeider
Copy link
Member Author

rolandgeider commented Jun 26, 2021

Common Olympic plate denominations are

kg: 1.25, 2.5, 5, 10, 15, 20, and 25 kg
lb: 2.5, 5, 10, 25, 35, and 45 lbs,

This should be chosen automatically based on the selected units in the current set

@rolandgeider rolandgeider added the good first issue Good for newcomers label Sep 16, 2021
@Shubhankaroad
Copy link

Hey @rolandgeider , i would like to work on this issue. Can you please assign it to me?

@rolandgeider
Copy link
Member Author

Sure

@rolandgeider
Copy link
Member Author

The plate calculator is used on the gym mode, just create a workout with a day and an exercise with some reps and weight

@Shubhankaroad
Copy link

Hey @rolandgeider i am facing an issue in running this flutter project on my local system. Below is the Screenshot of the same.
Screenshot from 2021-10-06 19-11-17
It would be really helpful if you could help me in solving this problem.

Actually this is the first time that i am working on an issue and also i am a beginner in flutter but i will try my best to solve the configure plate calculator issue.
Thanks

@rolandgeider
Copy link
Member Author

ahh, yes. One of the dependencies does not work with flutter 2.5., you should downgrade to 2.2. but if you can't change that, there's a workaround, set this version in the pubspec.yaml:

charts_flutter:
    git:
      url: https://github.com/google/charts
      path: charts_flutter

@Shubhankaroad
Copy link

Thanks @rolandgeider. I have downgraded to 2.2 and now it is working fine.

@rolandgeider
Copy link
Member Author

Great! If you have any other questions or something doesn't work, just ask 💪🏻

@Shubhankaroad
Copy link

How to login in to this application? Do i need to register as a user or is there any test server? And if there is any test server could you please tell me how to access it?

@rolandgeider
Copy link
Member Author

You will need to register manually on the testserver, then you can login using the username (be sure to click on "custom server" before): https://wger-master.rge.uber.space/

@Shubhankaroad
Copy link

Thank you so much @rolandgeider

@Shubhankaroad
Copy link

https://wger-master.rge.uber.space/ the website is showing
Invalid HTTP_HOST header: 'wger-master.rge.uber.space'. You may need to add 'wger-master.rge.uber.space' to ALLOWED_HOSTS.
Is there some issue form your side?

@rolandgeider
Copy link
Member Author

yes, it's on my side, I thought I had fixed that. I'll write you when it's up again

@Shubhankaroad
Copy link

Thanks @rolandgeider

@rolandgeider
Copy link
Member Author

can you try again?

@Shubhankaroad
Copy link

It's working fine now

@Shubhankaroad
Copy link

The plate calculator is used on the gym mode, just create a workout with a day and an exercise with some reps and weight

hey @rolandgeider i am unable to find the gym mode in the application. Can you please help me with it?

@rolandgeider
Copy link
Member Author

rolandgeider commented Oct 12, 2021

Sure. After adding some exercises to a day, you can swipe the day's header to the right (or click on the play button on the dashboard). Then on the gym mode when you arrive at the screen where you can log the weight the calculator will show you the necessary plates needed to reach the current weight

I'm not sure right now if we already added a check so that the plate generator only appears if the exercise uses barbels, so just add something like benchpress (or remove the check while you're developing)

@rolandgeider
Copy link
Member Author

@Shubhankaroad
Copy link

ohh thanks! found it

@toruwatanbe
Copy link

Hello @Shubhankaroad , is this issue closed, it still shows as Open, either way I would like to discuss this with you, please ping me on my email: jagrutdamdhar.mit@gmail.com, or it will be helpful even if you share your email. Thanks.

@rolandgeider
Copy link
Member Author

Hi @toruwatanbe, no this issue is still open

@rolandgeider
Copy link
Member Author

for ideas :)

https://www.barbellcalculator.com/

@AyushJagaty
Copy link

Hey @rolandgeider , i would like to work on this issue. Can you please assign it to me?

@rolandgeider
Copy link
Member Author

@AyushJagaty sure!

@AyushJagaty
Copy link

AyushJagaty commented Dec 10, 2024

i had raised a pr(Plate 46 calc #688) while installing i had encountred a issue regarding golden mismatching so i had used
flutter test --update-goldens command and the issue was resolved but when i pushed for pr the same test case failed .... so to try again i cloned once again to my machine and ran flutter test --coverage the same issue is persisting with another issue .. i am attaching screenshots for your reference .It would be really helpful if you could help me in solving this problem.

As a beginner in Flutter, this is my first time addressing an issue. I'm committed to resolving the configure plate calculator issue, and I'm open to any guidance or suggestions.

Image
Image
Image
Image

@rolandgeider
Copy link
Member Author

sorry @AyushJagaty just got around to reviewing it, just left you a couple of comments.

Yes, don't worry about the goldens, these depend a lot on operating systems, etc so if they were generated under linux, they will differ by a couple of pixels on windows and fail the text, you can just ignore these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Development

No branches or pull requests

4 participants