Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workout scheduler improvement - decoupling needed perhaps. #399

Closed
mhanuel26 opened this issue Jul 2, 2017 · 6 comments
Closed

Workout scheduler improvement - decoupling needed perhaps. #399

mhanuel26 opened this issue Jul 2, 2017 · 6 comments

Comments

@mhanuel26
Copy link

Hello,

I think the intuitive behavior and actually the one desired for scheduling workout sessions (at least for me) during a period is to be able to show the scheduled workout in the calendar, to explain better
I created a workout session (only one training day) that should be done on Tuesday, Thursday and Saturdays, then I schedule a workout using it for the next two weeks. But the workout isn't visible on the calendar unless I add the log, so what was the point to schedule it in first place?
Then I cannot filter by date to look at the workout for a given day easily or at least not using UI, is that available using the API?
Also if I want to repeat the same workout three days per week (I am doing a Full body workout which consist of the same exercises) but change the weights I want to lift on each workout session it cannot be done, so you have to create six (6) training days repeating the same exercises on them to specify weights and reps, but then the scheduling behavior described is the same.

Am I missing something here or the API need some decoupling, for example it would be great to have the workout separated completely from the data (weight, reps, etc), so users can add the same workouts and change the data for a given date in the calendar.

Please let me know your thoughts,

@mhanuel26
Copy link
Author

Hello Roland,

Did it make sense the above reasoning about workouts and scheduler?

Please let me know your comments,

@rolandgeider
Copy link
Member

rolandgeider commented Jul 24, 2017 via email

@mhanuel26
Copy link
Author

Hi Roland,

Thank you for your answer,

I was starting to think my comment about the scheduling was out of sense...

Yes I have experience in python, not too much with django but have used other frameworks.
I am willing to contribute here, I haven't take a look at source, I will do it asap and let you know when in doubt.

About brainstorm, first thing I would like to change is the workout, for me a "workout" is more a thing you do one day, then you can repeat the workout let's say three times a week, then you can call it "routine", so the routine is composed of a given workout performed three time per week.

More specific thing I would like to implement has to be with HST training, there are two basic concepts there that I will want to take into account when talking about "workouts". HST is based on "workout cycles" and it introduces (as far as I know but other training methods might have similar concept) the concept of macrocycle and mesocycle, a macrocycle is composed of three mesocycles. A mesocycle is composed of a certain number of workouts, for HST a minimum of 6 workouts.
The big difference between mesocycles in HST is the handle weights during the workouts, as you can perform an HST cycle using the same exercises. For HST a mesocycle takes two weeks so a cycle can take between 6 to 8 weeks, so basically you can perform the same workout week after week with a variation in the lifted weights.

So first thing would be to create the figure of a single day workout than can be scheduled for different days, those workouts per se should not have any weight information attached, rather that will come when schedules is done. Ideally, I would like to create the mesocycle figure or in more general sense a "routine" in which I can group a number of workouts evenly spaced on a period of time.

One more thing I noticed was the lack of API to handle the workout scheduling, it seems the things you can "currently" do using the web cannot be done (at least easily or in a intuitive manner) using the API. For example, once a workout is scheduled it was difficult for me to gather the exercises of it for example to create a "view" that shows you what to do on that day. Ideally I would like to do that and immediately or in real time be able to log each exercise performed.

What do you think?
Would you have a suggestion of where to start doing the modifications ?

Please let me know,

@dometto
Copy link

dometto commented Nov 24, 2020

, first thing I would like to change is the workout, for me a "workout" is more a thing you do one day, then you can repeat the workout let's say three times a week, then you can call it "routine", so the routine is composed of a given workout performed three time per week.

I would second this. Another reason for it is I might not have a specific day in the week for e.g. my 'Pull' day -- it might vary between Mondays and Tuesdays, say, depending on when I have time. Are any changes to the relationships between Workouts, programs, and days scheduled?

Thanks for your work on WGER by the way! Am finding it very useful.

@dometto
Copy link

dometto commented Jul 27, 2022

Isn't this superseded by #848?

@rolandgeider
Copy link
Member

yeah

@rolandgeider rolandgeider closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants