DataTab: Keep selection unchanged when appending received data

wh201906 · wh201906 · commit d10430cc3d47 · 2024-04-06T00:20:38.000+08:00
diff --git a/src/datatab.cpp b/src/datatab.cpp
@@ -469,7 +469,8 @@ void DataTab::appendSendedData(const QByteArray& data)
 // void MainWindow::syncEditWithData()
 void DataTab::appendReceivedData(const QByteArray &data, const QVector<Metadata>& metadata)
 {
-    int cursorPos;
+    // Record cursor position and selection
+    QTextCursor textCursor = ui->receivedEdit->textCursor();
     int sliderPos;
 
     if(!ui->receivedLatestBox->isChecked())
@@ -478,7 +479,6 @@ void DataTab::appendReceivedData(const QByteArray &data, const QVector<Metadata>
         sliderPos = RxSlider->sliderPosition();
     }
 
-    cursorPos = ui->receivedEdit->textCursor().position();
     ui->receivedEdit->moveCursor(QTextCursor::End);
     if(isReceivedDataHex)
     {
@@ -533,7 +533,7 @@ void DataTab::appendReceivedData(const QByteArray &data, const QVector<Metadata>
             ui->receivedEdit->insertPlainText(RxDecoder->toUnicode(dataItem));
         lastReceivedByte = *dataItem.crbegin();
     }
-    ui->receivedEdit->textCursor().setPosition(cursorPos);
+    ui->receivedEdit->setTextCursor(textCursor);
     if(!ui->receivedLatestBox->isChecked())
     {
         // Restore slider position

Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,8 @@ void DataTab::appendSendedData(const QByteArray& data)`
`469`	`469`	`// void MainWindow::syncEditWithData()`
`470`	`470`	`void DataTab::appendReceivedData(const QByteArray &data, const QVector<Metadata>& metadata)`
`471`	`471`	`{`
`472`		`- int cursorPos;`
	`472`	`+ // Record cursor position and selection`
	`473`	`+ QTextCursor textCursor = ui->receivedEdit->textCursor();`
`473`	`474`	`int sliderPos;`
`474`	`475`
`475`	`476`	`if(!ui->receivedLatestBox->isChecked())`
`@@ -478,7 +479,6 @@ void DataTab::appendReceivedData(const QByteArray &data, const QVector<Metadata>`
`478`	`479`	`sliderPos = RxSlider->sliderPosition();`
`479`	`480`	`}`
`480`	`481`
`481`		`- cursorPos = ui->receivedEdit->textCursor().position();`
`482`	`482`	`ui->receivedEdit->moveCursor(QTextCursor::End);`
`483`	`483`	`if(isReceivedDataHex)`
`484`	`484`	`{`
`@@ -533,7 +533,7 @@ void DataTab::appendReceivedData(const QByteArray &data, const QVector<Metadata>`
`533`	`533`	`ui->receivedEdit->insertPlainText(RxDecoder->toUnicode(dataItem));`
`534`	`534`	`lastReceivedByte = *dataItem.crbegin();`
`535`	`535`	`}`
`536`		`- ui->receivedEdit->textCursor().setPosition(cursorPos);`
	`536`	`+ ui->receivedEdit->setTextCursor(textCursor);`
`537`	`537`	`if(!ui->receivedLatestBox->isChecked())`
`538`	`538`	`{`
`539`	`539`	`// Restore slider position`