You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re-reading #9520 to give consistent names to the various "environment settings object" parameters, I noticed that the logic is still wrong.
Before that PR, the top-level worker module script was fetched with outside settings and its settings object was set to inside settings. Then, all its dependencies where fetched with inside settings and their settings object was inside settings.
After that PR, all its dependencies are fetched with outide settings and their settings object is outside settings.
Re-reading #9520 to give consistent names to the various "environment settings object" parameters, I noticed that the logic is still wrong.
where outside settings and inside settings are defined in https://html.spec.whatwg.org/#worker-processing-model
The settings object of all the dependencies should be inside settings instead, while keeping the fetch client as outside settings.
I will open a PR after #9530 is merged, assuming that it will happen soon.
(fyi @allstarschh)
The text was updated successfully, but these errors were encountered: