Skip to content

Latest commit

 

History

History
74 lines (64 loc) · 2.01 KB

checklist.md

File metadata and controls

74 lines (64 loc) · 2.01 KB
  1. [BEM] - Check your BEM structure using BEM-linter (npm run lint) and this list
  2. [BEM] - Make sure to follow BEM naming convention for complex modifiers: block-name--modifier-name--modifier-value;
  3. [BEM] - Create a separate file per each BEM block styles that have the same name as the block
  4. [SASS] - Make use of SASS nesting - write pseudo-class, pseudo-element selectors inside general selector. As well as media queries.

GOOD example:

&__buy-link {
  display: flex;
  margin-top: 20px;

  &:hover {
    color: blue;
  }
}

BAD example:

&__buy-link {
  display: flex;
  margin-top: 20px;
}

&__buy-link:hover {
  color: blue;
}
  1. [SASS] - Check your import syntax. It's differs from plain CSS.
  2. [SASS] - use variables for the main values so that you'll be able to reuse them and give them descriptive names. But don't overuse them, don't create variable for the value that's used just once.
  3. [SASS] - Don't use SASS loops for styles that stay the same for all elements of the group, e.g. display or position.
  4. [STYLES] - Make sure to list all styles that you apply transition to.
  5. [STYLES] - Make sure to add transition style under general selector, not the one with :hover - this way transition will work smoothly both ways.

GOOD example:

.box {
  color: gray;
  transition: color 0.5s, transform 0.5s;

  &:hover {
    color: aquamarine;
    transform: scale(1.2);
  }
}

BAD example:

.box {
  color: gray;

  &:hover {
    color: aquamarine;
    transform: scale(1.2);
    transition: 0.5s;
  }
}
  1. [FUNCTIONALITY] - Your project should work correctly (have 31 days and start on Monday) with invalid modifier values, like start-day--ghy or days--27.
  2. [STYLES] - Don't be greedy, add some top paddings, so the top row don't go over top of the page on hover.
  3. [CODE STYLE] - Remember about styles properties order - (css order)