Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestion Compensation #12

Open
valentinwust opened this issue Jul 8, 2024 · 1 comment
Open

Feature Suggestion Compensation #12

valentinwust opened this issue Jul 8, 2024 · 1 comment

Comments

@valentinwust
Copy link

Hello,

panelbuilder has some nice unmixing options that go beyond OLS. I haven't tried too much of it, but especially removing specific spectra from the data (e.g. an autofluorescence from single stain cells) seems interesting. I'll probably reproduce a lot of what they do in Python anyway, would you be interested in me adding that functionality to the package? Their special unmixing would add a torch dependency, but that could be treated as an optional dependency. (I could technically also implement it in pure numpy, but GPU support is pretty useful if the data get large.)

Greetings
Valentin

@whitews
Copy link
Owner

whitews commented Jul 15, 2024

Hi @valentinwust

Thanks for reaching out and apologies for the delayed response, I was out last week. I would be interested in this, though Torch is a pretty heavy dependency. How about we add this to the flowkit-extras package, which I by the issue you submitted there that you also found.

FlowKit-extras started as somewhat of a catch-all package for experimental ideas or things that don't fit nicely in the main packages (FlowIO, FlowUtils, and FlowKit). It's a playground where I don't worry about new dependencies so much. It would be nice to utilize the FlowKit Sample class for inputting the data to such a function. How does that sound?

Thanks again,
Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants