Skip to content

Commit fc0b06f

Browse files
committed
merge main
2 parents 8c3097c + f139ef8 commit fc0b06f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+15048
-24828
lines changed

.github/ISSUE_TEMPLATE/bug.md

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
---
2+
name: Bug report
3+
about: Report a bug in VHA
4+
title: "[BUG] "
5+
labels: bug
6+
assignees: ""
7+
---
8+
9+
<!-- feel free to delete any section and add comments freeform -->
10+
11+
### Description
12+
13+
<!-- A description of what the bug is -->
14+
15+
#### To Reproduce
16+
17+
1. 🖱
18+
2. 💥
19+
3. 🤦‍♂️
20+
21+
#### Expected behavior
22+
23+
<!-- What did you expect to happen? -->
24+
25+
#### Actual behavior
26+
27+
<!-- What happened instead? -->
28+
29+
#### Screenshot
30+
31+
<!-- If useful for explanation and easy to do consider adding a screenshot -->
32+
33+
#### Environment
34+
35+
- OS: `Windows` / `Mac` / `Linux`
36+
- VHA version: `3.2.0`
37+
38+
#### Additional context
39+
40+
<!-- any other comments -->

.github/ISSUE_TEMPLATE/feature.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
---
2+
name: Feature request
3+
about: Suggest a new feature for VHA
4+
title: "[FEATURE] "
5+
labels: enhancement
6+
assignees: ""
7+
---
8+
9+
<!-- feel free to delete any section and add comments freeform -->
10+
11+
### Description
12+
13+
<!-- Describe the feature or enhancement you'd like to see implemented in VHA -->
14+
15+
#### What problem does this solve?
16+
17+
<!-- Explain why this feature is important, what problem it solves, and how it benefits the users -->
18+
19+
#### Proposed Solution
20+
21+
<!-- Describe how the feature should work, providing examples if possible -->
22+
23+
#### Additional context
24+
25+
<!-- Add any other comments -->

.github/ISSUE_TEMPLATE/other.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
name: Other
3+
about: Anything related to VHA
4+
title: "[OTHER] "
5+
assignees: ""
6+
---
7+
8+
<!-- share a brief description of what you are thinking -->

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<!-- 🙇‍♂️ Thank you very much for contributing to VHA ♥ -->
2+
3+
Related issue: #{{issue number}}
4+
5+
<!-- please add any additional comments too -->

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v18.12.1
1+
v20.18.0

README.md

Lines changed: 26 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Video Hub App 3
22

3-
[*Video Hub App 3*](https://videohubapp.com/) is the fastest way to browse and search for videos on your computer. Think of it like YouTube for videos on your computer: browse, search, and preview. Works on Windows, Mac, and Linux!
4-
3+
[_Video Hub App 3_](https://videohubapp.com/) is the fastest way to browse and search for videos on your computer. Think of it like YouTube for videos on your computer: browse, search, and preview. Works on Windows, Mac, and Linux!
54

65
## Download Now
76

@@ -11,31 +10,26 @@ $3.50 of every sale goes to the [_cost-effective_](https://www.givewell.org/char
1110

1211
![video-hub-app](https://user-images.githubusercontent.com/17264277/82097107-3ed91700-96d0-11ea-8679-87fa3e07cd0b.jpg)
1312

14-
1513
## About
1614

17-
*Video Hub App* was created by [Boris Yakubchik](https://videohubapp.com/en/about). It uses the frameworks _Angular_ and _Electron_.
18-
15+
_Video Hub App_ was created by [Boris Yakubchik](https://videohubapp.com/en/about). It uses the frameworks _Angular_ and _Electron_.
1916

2017
## License
2118

2219
This software was built on top of [`angular-electron`](https://github.com/maximegris/angular-electron) by [Maxime GRIS](https://github.com/maximegris). It carries an _MIT_ license (see the _LICENSE_ file). While the license is permissive, I ask that you do not distribute free copies of this software unless you have significantly changed it.
2320

24-
2521
## Contributing
2622

27-
I would love to see the improvements you make to this app and am happy to accept pull requests. You can reach out if you'd like to coordinate / collaborate, or just *jump to [issues](https://github.com/whyboris/Video-Hub-App/issues)* to see what's already getting worked on and to add new suggestions!
23+
I would love to see the improvements you make to this app and am happy to accept pull requests. You can reach out if you'd like to coordinate / collaborate, or just _jump to [issues](https://github.com/whyboris/Video-Hub-App/issues)_ to see what's already getting worked on and to add new suggestions!
2824

2925
Please consider improving any of the translations, or [add a new translation](https://github.com/whyboris/Video-Hub-App/tree/master/i18n)!
3026

3127
Please consider improving or adding an icon to the app. It's a simple process, just [follow the instructions](https://github.com/whyboris/Video-Hub-App/tree/master/src/app/components/icon)!
3228

33-
3429
## Upcoming features
3530

3631
See [issues](https://github.com/whyboris/Video-Hub-App/issues) for what is in progress.
3732

38-
3933
## Development
4034

4135
⚠ The repository is usually ahead of the publicly [released version](https://github.com/whyboris/Video-Hub-App/releases) - it is 🚧 WIP and may have bugs in it.
@@ -48,45 +42,45 @@ How to start:
4842

4943
Main dependencies in use:
5044

51-
| Library | Version | Date | Comment |
52-
| ---------------- | --------- | -------------- | ------- |
53-
| Angular | v15.1.5 | Feb 2023 | |
54-
| Angular-CLI | v15.1.6 | Feb 2023 | |
55-
| Electron | v23.1.0 | Feb 2023 | (internally uses Node `v18.12.1` and Chromium 110) |
56-
| Electron Builder | v23.6.0 | Feb 2023 | |
45+
| Library | Version | Date | Comment |
46+
| ---------------- | ------- | --------- | ------- |
47+
| Angular | v18 | Oct 2024 | |
48+
| Angular-CLI | v18 | Oct 2024 | |
49+
| Electron | v33 | Oct 2024 | (internally uses Node `v20.18.0` and Chromium 128) |
50+
| Electron Builder | v25 | Oct 2024 | |
5751

58-
- **Node**: It may be best to use the same version as _Electron_ uses internally, but consider `v18.12.1`.
52+
- **Node**: It may be best to use the same version as _Electron_ uses internally (`v20.18.0`)
5953

6054
- **Angular CLI**: not required but may be useful: [Angular CLI](https://cli.angular.io).
6155

62-
To help debug a production build of VHA you can use [Debugtron](https://github.com/bytedance/debugtron)
56+
- **Mac**: We now have `M1` and `Intel` builds, but you may need to manually update the _FFmpeg_ and _FFprobe_ executables if you're building for a different architecture than you are on.
6357

58+
To help debug a production build of VHA you can use [Debugtron](https://github.com/bytedance/debugtron)
6459

6560
## Remote
6661

6762
👩‍🚀 a new feature in VHA is the option for the user to turn on a _server_ after the app starts. This will let the user open a simpler version of the VHA user interface on their phone or tablet (if both PC and device are on the same WiFi) and use it as remote control to play videos 🚀
6863

6964
For details, see [instructions](https://github.com/whyboris/Video-Hub-App/blob/master/remote/README.md).
7065

71-
7266
## Thank you
7367

7468
This software would not be possible without the tremendous work by other people:
7569

76-
- [Angular](https://github.com/angular/angular)
77-
- [Electron](https://github.com/electron/electron)
78-
- [FFmpeg](https://www.ffmpeg.org/)
79-
- [angular-electron](https://github.com/maximegris/angular-electron)
80-
- [ngx-virtual-scroller](https://github.com/rintoj/ngx-virtual-scroller)
81-
- [ffmpeg-static](https://github.com/eugeneware/ffmpeg-static)
82-
- [@ffprobe-installer/ffprobe](https://github.com/SavageCore/node-ffprobe-installer)
83-
- [ngx-translate](https://github.com/ngx-translate/core)
84-
- [fdir](https://github.com/thecodrr/fdir)
85-
- [async](https://github.com/caolan/async)
86-
- [chokidar](https://github.com/paulmillr/chokidar)
87-
- [trash](https://github.com/sindresorhus/trash)
88-
- [Fuse.js](https://github.com/krisk/Fuse)
89-
- [electron-window-state](https://github.com/mawie81/electron-window-state)
70+
- [Angular](https://github.com/angular/angular)
71+
- [Electron](https://github.com/electron/electron)
72+
- [FFmpeg](https://www.ffmpeg.org/)
73+
- [angular-electron](https://github.com/maximegris/angular-electron)
74+
- [ngx-virtual-scroller](https://github.com/rintoj/ngx-virtual-scroller)
75+
- [ffmpeg-static](https://github.com/eugeneware/ffmpeg-static)
76+
- [@ffprobe-installer/ffprobe](https://github.com/SavageCore/node-ffprobe-installer)
77+
- [ngx-translate](https://github.com/ngx-translate/core)
78+
- [fdir](https://github.com/thecodrr/fdir)
79+
- [async](https://github.com/caolan/async)
80+
- [chokidar](https://github.com/paulmillr/chokidar)
81+
- [trash](https://github.com/sindresorhus/trash)
82+
- [Fuse.js](https://github.com/krisk/Fuse)
83+
- [electron-window-state](https://github.com/mawie81/electron-window-state)
9084

9185
This software uses libraries from the FFmpeg project under the LGPLv2.1 with binaries from [here](https://github.com/kribblo/node-ffmpeg-installer#the-binaries)
9286

angular.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"projectType": "application",
1010
"architect": {
1111
"build": {
12-
"builder": "@angular-devkit/build-angular:browser-esbuild",
12+
"builder": "@angular-devkit/build-angular:browser",
1313
"options": {
1414
"outputPath": "dist",
1515
"index": "src/index.html",
@@ -68,14 +68,14 @@
6868
"serve": {
6969
"builder": "@angular-devkit/build-angular:dev-server",
7070
"options": {
71-
"browserTarget": "video-hub-app:build"
71+
"buildTarget": "video-hub-app:build"
7272
},
7373
"configurations": {
7474
"dev": {
75-
"browserTarget": "angular-electron:build:dev"
75+
"buildTarget": "angular-electron:build:dev"
7676
},
7777
"production": {
78-
"browserTarget": "angular-electron:build:production"
78+
"buildTarget": "angular-electron:build:production"
7979
}
8080
}
8181
},

electron-builder.json

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"productName": "Video Hub App 3",
33
"appId": "com.videohubapp.videohubapp3",
4-
"copyright": "Copyright © 2021 Boris Yakubchik",
4+
"copyright": "Copyright © 2023 Boris Yakubchik",
55
"directories": {
66
"output": "release/"
77
},
@@ -38,12 +38,19 @@
3838
"../node_modules/node-ffprobe-installer"
3939
],
4040
"target": [
41-
"nsis"
41+
"nsis",
42+
"portable"
4243
]
4344
},
4445
"mac": {
4546
"category": "public.app-category.video",
46-
"target": "dmg",
47+
"target": {
48+
"target": "dmg",
49+
"arch": [
50+
"x64",
51+
"arm64"
52+
]
53+
},
4754
"icon": "src/assets/icons.icns",
4855
"asar": true,
4956
"asarUnpack": [

0 commit comments

Comments
 (0)