Why/what is the purpose of the reference to "www.bestappsale.com" in GooglePlayApi.kt?

[capybara-overdose]

Hi!

Love Aurora store but just noticed this today after a comment on reddit:

I'm curious to know what this line is for? Seems odd for this app to be randomly referencing (contacting?) such a website?

GPlayApi/src/main/java/com/aurora/gplayapi/GooglePlayApi.kt

Line 222 in e90581f

const val SALES_URL = "https://www.bestappsale.com/api/android/getsale.php"

const val SALES_URL = "https://www.bestappsale.com/api/android/getsale.php"

Thanks!

[SkewedZeppelin]

added here e5cf914

It is used for the questionable "apps on sale" tab. I say questionable because you can't even buy apps via Aurora afaik.

see also https://gitlab.com/AuroraOSS/AuroraStore/-/issues/552

[capybara-overdose]

Aha! makes total sense. Thanks

[Elendil211]

It's also questionable whether this is needed. I would say it's not, and it's an unnecessary connection. It should at least be possible to disable it in the settings.

[capybara-overdose]

It's also questionable whether this is needed. I would say it's not, and it's an unnecessary connection. It should at least be possible to disable it in the settings.

agreed