TaskChunkSeries: Disallow start to be after end date

Author: wichmannpas

task/serializers.py

@@ -276,6 +276,11 @@ def validate(self, data):
             except ValidationError as error:
                 errors['monthly_day'].append(error)
 
+        end = data.get('end')
+        if start and end and start > end:
+            errors['start'] = 'start date may not be after the end date'
+            errors['end'] = 'end date may not be before the start date'
+
         if errors:
             raise ValidationError(errors)
 

task/tests.py

@@ -3608,6 +3608,46 @@ def test_validation_update_change_end(self):
             instance.end,
             date(2010, 5, 1))
 
+    def test_validation_create_start_after_end(self):
+        serializer = TaskChunkSeriesSerializer(data={
+            'task_id': self.task.pk,
+            'start': '2010-02-24',
+            'end': '2010-01-01',
+            'rule': 'interval',
+            'interval_days': 10,
+        }, context=self.context)
+        self.assertFalse(
+            serializer.is_valid())
+        self.assertSetEqual(
+            set(serializer.errors.keys()),
+            {
+                'start',
+                'end',
+            })
+
+    def test_validation_update_start_after_end(self):
+        instance = TaskChunkSeries.objects.create(
+            task=self.task,
+            start=date(2010, 2, 24),
+            rule='interval',
+            interval_days=10)
+
+        serializer = TaskChunkSeriesSerializer(instance=instance, data={
+            'task_id': self.task.pk,
+            'start': '2010-02-24',
+            'end': '2010-01-01',
+            'rule': 'interval',
+            'interval_days': 10,
+        }, context=self.context)
+        self.assertFalse(
+            serializer.is_valid())
+        self.assertSetEqual(
+            set(serializer.errors.keys()),
+            {
+                'start',
+                'end',
+            })
+
 
 class TaskChunkSeriesViewSetTest(AuthenticatedApiTest):
     def setUp(self):