From 436a5fbd9cfc0b5388089ea377955585dfbbf38b Mon Sep 17 00:00:00 2001
From: "Maarten A. Breddels" <maartenbreddels@gmail.com>
Date: Thu, 5 Sep 2024 12:41:15 +0200
Subject: [PATCH] small fixes

---
 pyinstaller/embedded_browser/render_test.vue        | 1 +
 pyinstaller/embedded_browser/test_pywebview.vue     | 1 -
 tests/qtapp/{test_pywebview.vue => render_test.vue} | 2 +-
 tests/qtapp/solara-qt-test.py                       | 2 +-
 tests/qtapp/test_app.py                             | 8 +++-----
 5 files changed, 6 insertions(+), 8 deletions(-)
 create mode 120000 pyinstaller/embedded_browser/render_test.vue
 delete mode 120000 pyinstaller/embedded_browser/test_pywebview.vue
 rename tests/qtapp/{test_pywebview.vue => render_test.vue} (90%)

diff --git a/pyinstaller/embedded_browser/render_test.vue b/pyinstaller/embedded_browser/render_test.vue
new file mode 120000
index 000000000..490700886
--- /dev/null
+++ b/pyinstaller/embedded_browser/render_test.vue
@@ -0,0 +1 @@
+../../tests/qtapp/render_test.vue
\ No newline at end of file
diff --git a/pyinstaller/embedded_browser/test_pywebview.vue b/pyinstaller/embedded_browser/test_pywebview.vue
deleted file mode 120000
index 5043eaa33..000000000
--- a/pyinstaller/embedded_browser/test_pywebview.vue
+++ /dev/null
@@ -1 +0,0 @@
-../../tests/qtapp/test_pywebview.vue
\ No newline at end of file
diff --git a/tests/qtapp/test_pywebview.vue b/tests/qtapp/render_test.vue
similarity index 90%
rename from tests/qtapp/test_pywebview.vue
rename to tests/qtapp/render_test.vue
index c010a01e7..4aaa87ec0 100644
--- a/tests/qtapp/test_pywebview.vue
+++ b/tests/qtapp/render_test.vue
@@ -6,7 +6,7 @@ module.exports = {
     mounted() {
         console.log("mounted")
         setTimeout(() => {
-            this.callback()
+            this.rendered()
         }, 1000)
     }
 }
diff --git a/tests/qtapp/solara-qt-test.py b/tests/qtapp/solara-qt-test.py
index 50853e161..25d4fcb4b 100644
--- a/tests/qtapp/solara-qt-test.py
+++ b/tests/qtapp/solara-qt-test.py
@@ -6,7 +6,7 @@
 import click
 import os
 
-# make sure you use pyside when distributing your all without having to use a GPL license
+# make sure you use pyside when distributing your app without having to use a GPL license
 from qtpy.QtWidgets import QApplication
 from qtpy.QtWebEngineWidgets import QWebEngineView
 from qtpy import QtCore
diff --git a/tests/qtapp/test_app.py b/tests/qtapp/test_app.py
index 959760c7b..923056e3c 100644
--- a/tests/qtapp/test_app.py
+++ b/tests/qtapp/test_app.py
@@ -6,15 +6,13 @@ def callback(event):
     print("Event received:", event)
 
 
-@solara.component_vue("test_pywebview.vue")
-def TestPywebview(event_callback):
+@solara.component_vue("rendered.vue")
+def RenderTest(event_rendered):
     pass
 
 
 @solara.component
 def Page():
-    TestPywebview(event_callback=callback)
+    RenderTest(event_rendered=callback)
     # make sure vue components of solara are working
     solara.lab.ThemeToggle()
-    # html = "<script>pywebview.api.test(\"Test passes!\")</script>Script tag inserted"
-    # solara.HTML(unsafe_innerHTML=html)