Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency on jQuery #153

Open
davidbarratt opened this issue Feb 26, 2018 · 5 comments
Open

Remove Dependency on jQuery #153

davidbarratt opened this issue Feb 26, 2018 · 5 comments

Comments

@davidbarratt
Copy link
Member

Is there any reason this library needs jQuery?

Perhaps the majority of this library should be moved to a generic JavaScript library and this package can wrap the new library with jQuery (in order to preserve backwards compatibility).

@santhoshtr
Copy link
Member

Yes, Agree. See #83. I started some initial work on this and now stalled due to time constraints.

@davidbarratt
Copy link
Member Author

I ended up creating React bindings for this library:
https://github.com/wikimedia/InteractionTimeline/tree/master/client/src/components/i18n
It can (and probably should) be split out into a separate library.

So in the end, I think it would be best if we had a JavaScript i18n library, and then a library that provides jQuery bindings and another that provides React bindings (or any other library someone wants to write bindings for)

@davidbarratt
Copy link
Member Author

I've moved the React bindings into a separate library: https://github.com/wikimedia/react.i18n

@santhoshtr
Copy link
Member

I am working on this again - to build a generic, modern js library https://github.com/santhoshtr/banana-i18n

Please take a look.

@davidbarratt
Copy link
Member Author

AMAZING!

I created a few issues for it. I don't see anything major. When it's published on npm I'll put it in https://github.com/wikimedia/react.i18n and see if the tests pass (I don't see why they wouldn't).

Thank you @santhoshtr for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants