Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixture teardowns may not run when another fixture fails #44

Open
gerlero opened this issue Aug 6, 2023 · 0 comments · May be fixed by #45
Open

Fixture teardowns may not run when another fixture fails #44

gerlero opened this issue Aug 6, 2023 · 0 comments · May be fixed by #45

Comments

@gerlero
Copy link
Contributor

gerlero commented Aug 6, 2023

The fixture collection logic does not seem to account for this case (neither before nor after #37), and so an exception raised while filling a fixture will not trigger the expected calls to the teardowns of any other fixtures that have already finished their setups.
@gerlero gerlero linked a pull request Aug 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tear down filled fixtures on fixture errors gerlero/pytest-asyncio-cooperative
1 participant
@gerlero