Skip to content

Request: pull icons and strings from Windows #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7kt4 opened this issue Sep 22, 2024 · 1 comment
Closed

Request: pull icons and strings from Windows #2215

7kt4 opened this issue Sep 22, 2024 · 1 comment
Assignees

Comments

@7kt4
Copy link

7kt4 commented Sep 22, 2024

Description of the feature, modification, idea or suggestion

If the icon or description for a program is pulled from an MUI, Windows uses it as its own. This program seems to not pull them/bypass this functionality. Idk if this is intentional functionality or unintended, but a setting to use the Windows-determined icons/descriptions would be nice.

Example (left: Windows decides icon/description in process hacker, for example)
imagen

Proposed implementation details (optional)

No response

@dmex dmex self-assigned this Mar 27, 2025
@dmex
Copy link
Collaborator

dmex commented Apr 8, 2025

If the icon or description for a program is pulled from an MUI, Windows uses it as its own. This program seems to not pull them/bypass this functionality. Idk if this is intentional functionality or unintended,

MUI support is handled by higher level Win32 functions (kernel32/kernelbase) but they also map files as executable by default due to legacy compatability. We're using low level Native API (ntdll) functions with the more modern/secure non-executable commit sections but never added the support for MUI files.

Fixed in the latest canary build.

@dmex dmex closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants