-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: defaultMeta returns object not string #2144
Comments
Out of curiosity, does this work in v3.7.0 and does it work in the latest version? Thanks to @maverick1872, 3.7.0 had a bunch of changes that might address this, but those changes were fairly quickly reverted due to an apparent bug. |
Whew. I've been out of the loop (life is a roller coaster) and haven't had time to come back around to this. I'm off Friday so I'll spend sometime fixing the underlying issue in #1989 in regards to Error Objects. @renanyoy if you don't mind testing this in the latest version to confirm it's still present that would be appreciated! |
@maverick1872 I have upgraded to winston 3.7.2 and it's same |
Seeing also if it works in 3.7.0 specifically helps figure out if that set of changes also addresses this problem. |
Me and other students can work on this issue. |
Thanks! Please first try to see if you can reproduce as described in the latest version, and then try 3.7.0 specifically, and report on whether that helps! |
Yes, we were able to reproduce the issue on 3.8.2 and on 3.7.2 (couldn't npm install 3.7.0). I think that the issue @renanyoy had comes from the formatting when ‘production’ is true, which invokes the ecsFormat. According to this ECS doc, the ‘service’ should be set as an object instead of a string, to something like A potential solution could just be reinitializing defaultMeta to |
What error did you encounter trying to install 3.7.0? |
I ran npm install winston@3.7.0 and was met with:
Here is what was inside the log: https://pastebin.com/u8NNmjrb I also ran npm install winston@3.7.1 which worked and I was able to reproduce the same issue. |
Hmm, OK, thanks for the report. It's disappointing that 3.7.1 didn't solve it. |
🔎 Search Terms
defaultmeta
The problem
defaultMeta does't appears as string in the log
but it displays service like that in the log
What version of Winston presents the issue?
v3.3.3
What version of Node are you using?
v16.15.0
If this worked in a previous version of Winston, which was it?
No response
Minimum Working Example
Additional information
No response
The text was updated successfully, but these errors were encountered: