Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Feb 9, 2026

https://wearezeta.atlassian.net/browse/WPB-23228

https://wearezeta.atlassian.net/browse/WPB-23228

What's new in this PR?

Updating persistentWebSocket preference for all users when enforced by MDM config.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Test Results

0 tests   - 4 331   0 ✅  - 4 214   0s ⏱️ - 5m 50s
0 suites  -   725   0 💤  -   117 
0 files    -   725   0 ❌ ±    0 

Results for commit 309f904. ± Comparison against base commit 3e70856.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🐰 Bencher Report

Branchmo/force-ws-enabled-via-mdm
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
709.56 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
423,225.80 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,351,807.38 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
22,181.00 µs
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 9, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 309f904 | Docs | Was this helpful? Give us feedback!

@sbakhtiarov sbakhtiarov changed the title Mo/force ws enabled via mdm feat: force ws enabled via mdm (WPB-23228) Feb 10, 2026
@sbakhtiarov sbakhtiarov marked this pull request as ready for review February 10, 2026 08:12
@sonarqubecloud
Copy link

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.67%. Comparing base (3e70856) to head (309f904).

Files with missing lines Patch % Lines
...Status/SetPersistentWebSocketForAllUsersUseCase.kt 0.00% 9 Missing ⚠️
...wire/kalium/persistence/daokaliumdb/AccountsDAO.kt 50.00% 0 Missing and 1 partial ⚠️
.../kotlin/com/wire/kalium/logic/GlobalKaliumScope.kt 0.00% 1 Missing ⚠️
...ire/kalium/logic/data/session/SessionRepository.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3855      +/-   ##
===========================================
+ Coverage    59.57%   59.67%   +0.10%     
===========================================
  Files         1900     1901       +1     
  Lines        59466    59485      +19     
  Branches      6456     6459       +3     
===========================================
+ Hits         35426    35497      +71     
+ Misses       21073    21016      -57     
- Partials      2967     2972       +5     
Files with missing lines Coverage Δ
...wire/kalium/persistence/daokaliumdb/AccountsDAO.kt 65.11% <50.00%> (+20.23%) ⬆️
.../kotlin/com/wire/kalium/logic/GlobalKaliumScope.kt 0.00% <0.00%> (ø)
...ire/kalium/logic/data/session/SessionRepository.kt 0.00% <0.00%> (ø)
...Status/SetPersistentWebSocketForAllUsersUseCase.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e70856...309f904. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants