[1.21] Constant Breaking sound with Incorrect code from Better End Elytra API

[ENDERSTIXgaming]

I have an elytra in the cape slot and it makes an item break sound over and over while flying even if it doesn't lose durability cause UNB 3. obv the item break sound should only play when it runs out of durability. I tried the elytra in my chestplate slot and it doesn't make that sound but if it's in the cape slot it does

accessories-fabric-1.0.0-beta.33+1.21.jar

[Dragon-Seeker]

Are you using the compat layers and what is the elytra mod exactly?

[ENDERSTIXgaming]

I have accessories_tclayer-3.10.0-beta.10+1.21.jar
accessories-fabric-1.0.0-beta.34+1.21.jar
trinkets-3.10.0.jar
and elytraslot-fabric-9.0.0+1.21.jar

(if there's a mod I didn't list that I need I MIGHT have it lmk what to look for and I'll look for it)

[Dragon-Seeker]

Ok, will investigate the issue futher

[Dragon-Seeker]

Tried to reproduce the issues but had not such problem... frankly couldn't get the elytra to make any breaking noise.

[Dragon-Seeker]

Could you be able to post a video of the issue?

[ENDERSTIXgaming]

having trouble uploading the video. it's too big.

[ENDERSTIXgaming]

seems to only happen with soul elytra from deeper and darker
https://github.com/user-attachments/assets/6ebb7d8d-bbf7-4ab4-abdd-b58f5b467903

[EvilVoids]

I have discovered a possible fix. I believe it is cause from the accessories mods which allows the shift click into accessory slots. What I did to fix what apply the Dragon Chest Piece from the dragon loot mod in an accessory slot and it seemed to fix the problem. This may or may not work with other elytra but that is what I found that fixed it.

[Suleos]

I was looking at your mod list because I was having the same exact issue, this is actually caused by BetterEnd. Removing it will solve the problem, but of course that's not a great fix all things considered.

[Dragon-Seeker]

...this is actually caused by BetterEnd.

If such is true then its quite a weird bug, to say the least.

[Dragon-Seeker]

It seems the issue has been found to be a problem with a portion of Better End code that also causes this issue for Trinkets as stated here and here with the issue resolvable by fixing some code within Better End here with the adjusted code below but it is at this time the Developers of the Mod are not maintaining such further so this issue can not be resolved unless action is taken on Better End Team:

BCLElytraUtils.onBreak = (entity, chestStack) -> {
    var oTrinketComponent = TrinketsApi.getTrinketComponent(entity);

    var possibleTrinketSlot = null;

    if (oTrinketComponent.isPresent()) {
        List<Tuple<SlotReference, ItemStack>> equipped = oTrinketComponent.get().getEquipped(Elytra::isElytra);

        for (var slot : equipped) {
            var slotStack = slot.getB();
            if (slotStack == chestStack) {
                possibleTrinketSlot = slot.getA();
                break;
            }
        }
    }
    
    if (possibleTrinketSlot == null) {
        chestStack.hurtAndBreak(1, entity, EquipmentSlot.CHEST);
    } else if(entity instanceof ServerPlayer player) {
        // Mostly 1:1 copy of Fabric API handling for having custom damage handler for breaking: https://github.com/FabricMC/fabric/blob/5ca99b905c7ea1ddfe796066fc10b0d16e37d869/fabric-item-api-v1/src/main/java/net/fabricmc/fabric/mixin/item/ItemStackMixin.java#L49
        int hurtAmount = 1;

        Consumer<Item> onBreakConsumer = (item) -> {
            TrinketsApi.onTrinketBroken(chestStack, possibleTrinketSlot, player);
        };

        var handler = ((ItemExtensions)chestStack.getItem()).fabric_getCustomDamageHandler();
        if (handler != null && !player.isInCreativeMode()) {
            // Track whether an item has been broken by custom handler
            var isBroken = new MutableBoolean(false);

            hurtAmount = handler.damage(chestStack, amount, player, EquipmentSlot.CHEST, () -> {
                isBroken.setTrue();
                chestStack.decrement(1);
                onBreakConsumer.accept(this.getItem());
            });

              // If item is broken, there's no reason to call the original.
              if (isBroken.booleanValue()) return;
        } 

        chestStack.hurtAndBreak(hurtAmount, (ServerLevel) player.level(), player, onBreakConsumer);
    }
};