Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include validator pkh in the QR generated by authorizeStake CLI method #2541

Open
Tommytrg opened this issue Nov 25, 2024 · 1 comment · May be fixed by #2567
Open

Include validator pkh in the QR generated by authorizeStake CLI method #2541

Tommytrg opened this issue Nov 25, 2024 · 1 comment · May be fixed by #2567
Assignees
Labels
2.0 enhancement 📈 New feature or request

Comments

@Tommytrg
Copy link
Member

Tommytrg commented Nov 25, 2024

The authorizeStake CLI method generates a QR code with the authorization to be scanned from myWitWallet. The way that is implemented right now in myWitWallet also includes an input for the withdrawal pkh to be introduced by the user.

We could improve the UX including the withdrawal pkh in the QR code in the following way allowing myWitWallet to complete the form itself:

<withdrawal>:<authorization (recoveryID,secp256k1[R,S)]>

It could be convenient to also log the authorization without the withdrawal

@Tommytrg Tommytrg changed the title Inlude withdrawer in the QR generated by authorizeStake CLI method Inlude withdrawal pkh in the QR generated by authorizeStake CLI method Nov 25, 2024
@Tommytrg
Copy link
Member Author

Tommytrg commented Dec 2, 2024

Hey team! Please add your planning poker estimate with Zenhub @aesedepece @aeweda @gabaldon @guidiaz

@Tommytrg Tommytrg changed the title Inlude withdrawal pkh in the QR generated by authorizeStake CLI method Inlude validator pkh in the QR generated by authorizeStake CLI method Dec 2, 2024
@aesedepece aesedepece added enhancement 📈 New feature or request 2.0 labels Dec 16, 2024
@aesedepece aesedepece changed the title Inlude validator pkh in the QR generated by authorizeStake CLI method Include validator pkh in the QR generated by authorizeStake CLI method Dec 16, 2024
@Tommytrg Tommytrg linked a pull request Jan 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 enhancement 📈 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants