Failures were seen in MSI Unit Tests around Firewall rules within

Windows Sandbox.

This is potentially a Windows OS bug (it was from a Windows Insider build),
however shows that it's possible in the Firewall API to have multiple rules
which differ only in their Grouping.
So the testbench should consider different Grouping as making for a unique
firewall rule.


Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>

Author: bevanweiss

src/test/burn/WixTestTools/Firewall/UniqueCheck.cs

@@ -23,6 +23,7 @@ public UniqueCheck(RuleDetails details)
             this.ApplicationName = details.ApplicationName;
             this.LocalUserOwner = details.LocalUserOwner;
             this.RemoteAddresses = details.RemoteAddresses;
+            this.Grouping = details.Grouping;
         }
 
 
@@ -40,6 +41,8 @@ public UniqueCheck(RuleDetails details)
 
         public string RemoteAddresses { get; set; }
 
+        public string Grouping { get; set; }
+
         public bool FirewallRuleIsUnique(INetFwRule3 rule)
         {
             if (this.Name != null && rule.Name != this.Name)
@@ -77,6 +80,11 @@ public bool FirewallRuleIsUnique(INetFwRule3 rule)
                 return false;
             }
 
+            if (this.Grouping != null && rule.Grouping != this.Grouping)
+            {
+                return false;
+            }
+
             return true;
         }
     }