Net8, and a bunch of other dependency updates #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versioned up to .NET 8.0.7 patches Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
with the System.Memory update (and binding) Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
Thanks, but we're not moving to .NET 8.0 in WiX v6. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boosts up almost all of the WiX dependencies to their latest versions.
Main issue that arose was around System.Memory.dll binding with heat.exe and the updated MSBuild libraries.
Matching the upstream MSBuild bindingRedirections for System.Memory.dll appeared to resolve this.
I've run through the various Integration tests (Burn + MSI) after the build completed successfully, all worked as expected.
None of the non net6.0 targets have been touched, so net4xx (framework) support should remain as it was.
Have also not run any 'out of flow' testing over various environments like .NET 4.7.2 etc however, so a library conflict somewhere may cause an as yet unrevealed issue. Happy to run additional tests if there's info available for them.