Skip to content

Commit 35f6ae2

Browse files
committed
Style mobile full page close buttons
The mobile full pages are now modals meaning the close button should be absolutely positioned. This also adds a background to the buttons so they look okay when they cover other elements.
1 parent b978ba1 commit 35f6ae2

File tree

4 files changed

+29
-11
lines changed

4 files changed

+29
-11
lines changed

banners/mobile/styles/FullPageBanner.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
width: 100vw;
1414

1515
&-content {
16-
overflow-y: scroll;
16+
overflow-y: auto;
1717
height: 100%;
1818
width: 100%;
1919
}
@@ -26,8 +26,12 @@
2626
position: absolute;
2727
top: 16px;
2828
right: 16px;
29-
height: 25px;
29+
height: 35px;
30+
width: 35px;
31+
padding: 5px;
3032
background: colors.$white;
33+
z-index: 99;
34+
border-radius: 50%;
3135

3236
&:hover {
3337
cursor: pointer;

banners/mobile_english/components/FullPageBanner.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<template>
22
<div class="wmde-banner-full">
3-
<div class="wmde-banner-full-content">
3+
<button class="wmde-banner-full-close t-close-full-banner" @click.prevent="$emit( 'close' )">
4+
<CloseIconChunky/>
5+
</button>
46

5-
<button class="wmde-banner-full-close t-close-full-banner" @click.prevent="$emit( 'close' )">
6-
<CloseIconChunky/>
7-
</button>
7+
<div class="wmde-banner-full-content">
88

99
<header class="wmde-banner-headline">
1010
<span class="wmde-banner-headline-content">the wikimedia fundraising campaign</span>

banners/mobile_english/styles/FullPageBanner.scss

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
z-index: 1000;
99
height: 100%;
1010
width: 100%;
11-
overflow-y: auto;
1211
background: colors.$primary-lighter;
1312
box-shadow: 0 7px 22px 0 rgba( 0, 0, 0, 0.35 );
1413
text-align: center;
@@ -18,11 +17,22 @@
1817
border: 8px solid colors.$primary;
1918
padding: 5px 5px 15px;
2019

20+
&-content {
21+
overflow-y: auto;
22+
height: 100%;
23+
width: 100%;
24+
}
25+
2126
&-close {
2227
position: absolute;
23-
top: 8px;
24-
right: 8px;
28+
top: 3px;
29+
right: 3px;
2530
z-index: 2;
31+
height: 36px;
32+
width: 36px;
33+
padding: 5px;
34+
border-radius: 50%;
35+
background: colors.$primary-lighter;
2636
}
2737

2838
&-info {

banners/wpde_mobile/styles/FullPageBanner.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
width: 100vw;
1818

1919
&-content {
20-
overflow-y: scroll;
20+
overflow-y: auto;
2121
height: 100%;
2222
width: 100%;
2323
}
@@ -32,8 +32,12 @@
3232
position: absolute;
3333
top: 16px;
3434
right: 16px;
35-
height: 25px;
35+
height: 35px;
36+
width: 35px;
37+
padding: 5px;
3638
background: colors.$white;
39+
z-index: 99;
40+
border-radius: 50%;
3741
border: 0;
3842

3943
&:hover {

0 commit comments

Comments
 (0)