Add explicit function return types

Author: wojtekmaj

packages/react-pdf/src/Document.tsx

@@ -232,7 +232,7 @@ function isParameterObject(file: File): file is Source {
 /**
  * Loads a document passed using `file` prop.
  */
-const Document = forwardRef(function Document(
+const Document: React.ForwardRefExoticComponent<DocumentProps> = forwardRef(function Document(
   {
     children,
     className,
@@ -255,7 +255,7 @@ const Document = forwardRef(function Document(
     renderMode,
     rotate,
     ...otherProps
-  }: DocumentProps,
+  },
   ref,
 ) {
   const [sourceState, sourceDispatch] = useResolver<Source | null>();

packages/react-pdf/src/DocumentContext.tsx

@@ -4,4 +4,7 @@ import { createContext } from 'react';
 
 import type { DocumentContextType } from './shared/types.js';
 
-export default createContext<DocumentContextType>(null);
+const documentContext: React.Context<DocumentContextType> =
+  createContext<DocumentContextType>(null);
+
+export default documentContext;

packages/react-pdf/src/LinkService.ts

@@ -49,31 +49,31 @@ export default class LinkService implements IPDFLinkService {
     this.pdfViewer = undefined;
   }
 
-  setDocument(pdfDocument: PDFDocumentProxy) {
+  setDocument(pdfDocument: PDFDocumentProxy): void {
     this.pdfDocument = pdfDocument;
   }
 
-  setViewer(pdfViewer: PDFViewer) {
+  setViewer(pdfViewer: PDFViewer): void {
     this.pdfViewer = pdfViewer;
   }
 
-  setExternalLinkRel(externalLinkRel?: ExternalLinkRel) {
+  setExternalLinkRel(externalLinkRel?: ExternalLinkRel): void {
     this.externalLinkRel = externalLinkRel;
   }
 
-  setExternalLinkTarget(externalLinkTarget?: ExternalLinkTarget) {
+  setExternalLinkTarget(externalLinkTarget?: ExternalLinkTarget): void {
     this.externalLinkTarget = externalLinkTarget;
   }
 
-  setHistory() {
+  setHistory(): void {
     // Intentionally empty
   }
 
-  get pagesCount() {
+  get pagesCount(): number {
     return this.pdfDocument ? this.pdfDocument.numPages : 0;
   }
 
-  get page() {
+  get page(): number {
     invariant(this.pdfViewer, 'PDF viewer is not initialized.');
 
     return this.pdfViewer.currentPageNumber || 0;
@@ -85,7 +85,7 @@ export default class LinkService implements IPDFLinkService {
     this.pdfViewer.currentPageNumber = value;
   }
 
-  get rotation() {
+  get rotation(): number {
     return 0;
   }
 
@@ -147,11 +147,11 @@ export default class LinkService implements IPDFLinkService {
     });
   }
 
-  navigateTo(dest: Dest) {
+  navigateTo(dest: Dest): void {
     this.goToDestination(dest);
   }
 
-  goToPage(pageNumber: number) {
+  goToPage(pageNumber: number): void {
     const pageIndex = pageNumber - 1;
 
     invariant(this.pdfViewer, 'PDF viewer is not initialized.');
@@ -167,41 +167,41 @@ export default class LinkService implements IPDFLinkService {
     });
   }
 
-  addLinkAttributes(link: HTMLAnchorElement, url: string, newWindow: boolean) {
+  addLinkAttributes(link: HTMLAnchorElement, url: string, newWindow: boolean): void {
     link.href = url;
     link.rel = this.externalLinkRel || DEFAULT_LINK_REL;
     link.target = newWindow ? '_blank' : this.externalLinkTarget || '';
   }
 
-  getDestinationHash() {
+  getDestinationHash(): string {
     return '#';
   }
 
-  getAnchorUrl() {
+  getAnchorUrl(): string {
     return '#';
   }
 
-  setHash() {
+  setHash(): void {
     // Intentionally empty
   }
 
-  executeNamedAction() {
+  executeNamedAction(): void {
     // Intentionally empty
   }
 
-  cachePageRef() {
+  cachePageRef(): void {
     // Intentionally empty
   }
 
-  isPageVisible() {
+  isPageVisible(): boolean {
     return true;
   }
 
-  isPageCached() {
+  isPageCached(): boolean {
     return true;
   }
 
-  executeSetOCGState() {
+  executeSetOCGState(): void {
     // Intentionally empty
   }
 }

packages/react-pdf/src/Message.tsx

@@ -3,6 +3,6 @@ type MessageProps = {
   type: 'error' | 'loading' | 'no-data';
 };
 
-export default function Message({ children, type }: MessageProps) {
+export default function Message({ children, type }: MessageProps): React.ReactElement {
   return <div className={`react-pdf__message react-pdf__message--${type}`}>{children}</div>;
 }

packages/react-pdf/src/Outline.tsx

@@ -64,7 +64,7 @@ export type OutlineProps = {
  *
  * Should be placed inside `<Document />`. Alternatively, it can have `pdf` prop passed, which can be obtained from `<Document />`'s `onLoadSuccess` callback function.
  */
-export default function Outline(props: OutlineProps) {
+export default function Outline(props: OutlineProps): React.ReactNode {
   const documentContext = useDocumentContext();
 
   const mergedProps = { ...documentContext, ...props };

packages/react-pdf/src/OutlineContext.tsx

@@ -4,4 +4,6 @@ import { createContext } from 'react';
 
 import type { OutlineContextType } from './shared/types.js';
 
-export default createContext<OutlineContextType>(null);
+const outlineContext: React.Context<OutlineContextType> = createContext<OutlineContextType>(null);
+
+export default outlineContext;

packages/react-pdf/src/OutlineItem.tsx

@@ -18,7 +18,7 @@ type OutlineItemProps = {
   pdf?: PDFDocumentProxy | false;
 };
 
-export default function OutlineItem(props: OutlineItemProps) {
+export default function OutlineItem(props: OutlineItemProps): React.ReactElement {
   const documentContext = useDocumentContext();
 
   const outlineContext = useOutlineContext();

packages/react-pdf/src/Page.tsx

@@ -300,7 +300,7 @@ export type PageProps = {
  *
  * Should be placed inside `<Document />`. Alternatively, it can have `pdf` prop passed, which can be obtained from `<Document />`'s `onLoadSuccess` callback function, however some advanced functions like linking between pages inside a document may not be working correctly.
  */
-export default function Page(props: PageProps) {
+export default function Page(props: PageProps): React.ReactElement {
   const documentContext = useDocumentContext();
 
   const mergedProps = { ...documentContext, ...props };

packages/react-pdf/src/Page/AnnotationLayer.tsx

@@ -14,7 +14,7 @@ import { cancelRunningTask } from '../shared/utils.js';
 
 import type { Annotations } from '../shared/types.js';
 
-export default function AnnotationLayer() {
+export default function AnnotationLayer(): React.ReactElement {
   const documentContext = useDocumentContext();
   const pageContext = usePageContext();
 

packages/react-pdf/src/Page/Canvas.tsx

@@ -24,7 +24,7 @@ type CanvasProps = {
   canvasRef?: React.Ref<HTMLCanvasElement>;
 };
 
-export default function Canvas(props: CanvasProps) {
+export default function Canvas(props: CanvasProps): React.ReactElement {
   const pageContext = usePageContext();
 
   invariant(pageContext, 'Unable to find Page context.');