You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The calculation and the messages are inappropriate for the current Hactoberfest and maybe future ones, so there is a clear need to upgrade the system with the above mentioned flexibility!
The text was updated successfully, but these errors were encountered:
ocReaper
changed the title
Needs a way to dinamically set the amount of required PRs
Needs a way to dynamically set the amount of required PRs
Oct 29, 2019
@ocReaper Although we have a variable to set the amount of required PRs (which I'm refreshing every year, by the way), you are right about the messages being incorrect. How do you think the ideal solution could work?
One idea I came up with while reading the issue is maybe we could get rid of how the messages are "categorized" by number of completed PRs now, and instead go around by loading them based on number of missing PRs, something like this:
0 missing -> "Congrats, you're done"-type of messages
1 missing -> "Almost there!"
2 missing -> "So far so good"
>=3 missing -> "You can do better."
That would mean even if DigitalOcean decides next year you'll need 10 PRs to complete the challenge, we'd need no change regarding the messages, we'd only need to update the variable we have now.
The calculation and the messages are inappropriate for the current Hactoberfest and maybe future ones, so there is a clear need to upgrade the system with the above mentioned flexibility!
The text was updated successfully, but these errors were encountered: