Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs a way to dynamically set the amount of required PRs #9

Open
ocReaper opened this issue Oct 29, 2019 · 2 comments
Open

Needs a way to dynamically set the amount of required PRs #9

ocReaper opened this issue Oct 29, 2019 · 2 comments

Comments

@ocReaper
Copy link

The calculation and the messages are inappropriate for the current Hactoberfest and maybe future ones, so there is a clear need to upgrade the system with the above mentioned flexibility!

@ocReaper ocReaper changed the title Needs a way to dinamically set the amount of required PRs Needs a way to dynamically set the amount of required PRs Oct 29, 2019
@wolfika
Copy link
Owner

wolfika commented Oct 30, 2019

@ocReaper Although we have a variable to set the amount of required PRs (which I'm refreshing every year, by the way), you are right about the messages being incorrect. How do you think the ideal solution could work?

One idea I came up with while reading the issue is maybe we could get rid of how the messages are "categorized" by number of completed PRs now, and instead go around by loading them based on number of missing PRs, something like this:

0 missing -> "Congrats, you're done"-type of messages
1 missing -> "Almost there!"
2 missing -> "So far so good"
>=3 missing -> "You can do better."

That would mean even if DigitalOcean decides next year you'll need 10 PRs to complete the challenge, we'd need no change regarding the messages, we'd only need to update the variable we have now.

@ocReaper
Copy link
Author

Excellent idea! I'll make a PR probably later today! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants