Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement features from jekyll-seo-tag #6

Open
fititnt opened this issue Sep 10, 2016 · 1 comment
Open

Implement features from jekyll-seo-tag #6

fititnt opened this issue Sep 10, 2016 · 1 comment

Comments

@fititnt
Copy link

fititnt commented Sep 10, 2016

Check a few features from https://github.com/jekyll/jekyll-seo-tag. We use it at webiwg/webiwg-issues#11. It is whitelisted for github pages. If does not add jekyll-seo-tag, I guess that would be nice to at least add hese twitter cards and facebook stuff.

Also it make use of some _data/* and organize ident the code a little different, like

facebook:
  app_id: 1234
  publisher: 1234
  admins: 1234

instead of

facebook_app_id: 1234
facebook_publisher: 1234
facebook_admins: 1234

I'm not one expert on jekyll/ruby, so maybe my suggestions now are not very good

@woliveiras
Copy link
Owner

Great!

I use like this: https://github.com/woliveiras/__s/blob/master/_includes/head.html

But jekyll-seo-tag is cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants