Skip to content

Commit dca2249

Browse files
fix SmoothingETA using the value returned by smoothing_algorithm
1 parent ef3c045 commit dca2249

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

progressbar/widgets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ def __call__(
682682
if elapsed is None: # pragma: no branch
683683
elapsed = data['time_elapsed']
684684

685-
self.smoothing_algorithm.update(value, elapsed)
685+
value = self.smoothing_algorithm.update(value, elapsed)
686686
return ETA.__call__(self, progress, data, value=value, elapsed=elapsed)
687687

688688

tests/test_monitor_progress.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ def test_list_example(testdir) -> None:
8585
pprint.pprint(result.stderr.lines, width=70)
8686
result.stderr.fnmatch_lines([
8787
' 0% (0 of 9) | | Elapsed Time: ?:00:00 ETA: --:--:--',
88-
' 11% (1 of 9) |# | Elapsed Time: ?:00:01 ETA: ?:00:08',
89-
' 22% (2 of 9) |## | Elapsed Time: ?:00:02 ETA: ?:00:07',
90-
' 33% (3 of 9) |#### | Elapsed Time: ?:00:03 ETA: ?:00:06',
91-
' 44% (4 of 9) |##### | Elapsed Time: ?:00:04 ETA: ?:00:05',
88+
' 11% (1 of 9) |# | Elapsed Time: ?:00:01 ETA: ?:00:16',
89+
' 22% (2 of 9) |## | Elapsed Time: ?:00:02 ETA: ?:00:11',
90+
' 33% (3 of 9) |#### | Elapsed Time: ?:00:03 ETA: ?:00:08',
91+
' 44% (4 of 9) |##### | Elapsed Time: ?:00:04 ETA: ?:00:06',
9292
' 55% (5 of 9) |###### | Elapsed Time: ?:00:05 ETA: ?:00:04',
9393
' 66% (6 of 9) |######## | Elapsed Time: ?:00:06 ETA: ?:00:03',
9494
' 77% (7 of 9) |######### | Elapsed Time: ?:00:07 ETA: ?:00:02',
@@ -144,14 +144,14 @@ def test_rapid_updates(testdir) -> None:
144144
result.stderr.fnmatch_lines(
145145
[
146146
' 0% (0 of 10) | | Elapsed Time: 0:00:00 ETA: --:--:--',
147-
' 10% (1 of 10) | | Elapsed Time: 0:00:01 ETA: 0:00:09',
148-
' 20% (2 of 10) |# | Elapsed Time: 0:00:02 ETA: 0:00:08',
149-
' 30% (3 of 10) |# | Elapsed Time: 0:00:03 ETA: 0:00:07',
150-
' 40% (4 of 10) |## | Elapsed Time: 0:00:04 ETA: 0:00:06',
151-
' 50% (5 of 10) |### | Elapsed Time: 0:00:05 ETA: 0:00:05',
152-
' 60% (6 of 10) |### | Elapsed Time: 0:00:07 ETA: 0:00:04',
153-
' 70% (7 of 10) |#### | Elapsed Time: 0:00:09 ETA: 0:00:03',
154-
' 80% (8 of 10) |#### | Elapsed Time: 0:00:11 ETA: 0:00:02',
147+
' 10% (1 of 10) | | Elapsed Time: 0:00:01 ETA: 0:00:18',
148+
' 20% (2 of 10) |# | Elapsed Time: 0:00:02 ETA: 0:00:12',
149+
' 30% (3 of 10) |# | Elapsed Time: 0:00:03 ETA: 0:00:09',
150+
' 40% (4 of 10) |## | Elapsed Time: 0:00:04 ETA: 0:00:07',
151+
' 50% (5 of 10) |### | Elapsed Time: 0:00:05 ETA: 0:00:06',
152+
' 60% (6 of 10) |### | Elapsed Time: 0:00:07 ETA: 0:00:05',
153+
' 70% (7 of 10) |#### | Elapsed Time: 0:00:09 ETA: 0:00:04',
154+
' 80% (8 of 10) |#### | Elapsed Time: 0:00:11 ETA: 0:00:03',
155155
' 90% (9 of 10) |##### | Elapsed Time: 0:00:13 ETA: 0:00:01',
156156
'100% (10 of 10) |#####| Elapsed Time: 0:00:15 Time: 0:00:15',
157157
],

0 commit comments

Comments
 (0)