Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated tests for formatting products #442

Open
tomalec opened this issue Jun 19, 2024 · 0 comments
Open

Add automated tests for formatting products #442

tomalec opened this issue Jun 19, 2024 · 0 comments
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@tomalec
Copy link
Member

tomalec commented Jun 19, 2024

This is a follow-up from #439

UserDeveloper story

As a developer, I'd like to have automated tests to help me assert the quality of the extension in regards to tracked product data.

Is your feature request related to a problem?

get_formatted_product is not covered by tests

How to reproduce the problem

Describe the solution you'd like

We could add PHP unit tests to check get_formatted_product for simple, variable and bundled products.
We can also consider adding E2Es to somewhat test Block-based events' data.

Describe alternatives you've considered

Technical

Acceptance criteria

Unknowns

Out of bounds/rabbit holes
@tomalec tomalec added type: enhancement The issue is a request for an enhancement. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves the technical debt of the project. labels Jun 19, 2024
@tomalec tomalec mentioned this issue Jun 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomalec