Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses: coordinates: be fully general over step inputs #390

Open
woodruffw opened this issue Jan 5, 2025 · 0 comments
Open

uses: coordinates: be fully general over step inputs #390

woodruffw opened this issue Jan 5, 2025 · 0 comments

Comments

@woodruffw
Copy link
Owner

#378 (comment) is an example of a false positive that we currently struggle to suppress, due to limitations to UsesCoordinate's expressiveness.

In particular, we can't currently express a condition like "this action is only relevant if foo: A and bar: B or baz: /regexp/."

To express those kinds of sentential logic chains we'll need to generalize UsesCoordinate::control to be something like controls instead, where controls will be a boolean expression of different propositions (basic matches, but also regular expressions).

I'm currently considering this low-ish priority, since doing it right is (1) tricky, and (2) only (so far) benefits a niche case that we can't yet analyze anyways (since cache-from: type=gha,ref=${{ github.run_id }} isn't something we can analyze yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant