Skip to content

Commit 1eb2530

Browse files
authored
Merge pull request #1391 from woowacourse/feature/1357-roadmap-update
Feature/#1357 로드맵 답변 수정 기능
2 parents 9dd8c05 + 52c9afc commit 1eb2530

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

backend/src/main/java/wooteco/prolog/roadmap/application/EssayAnswerService.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
package wooteco.prolog.roadmap.application;
22

3-
import java.util.List;
43
import org.hibernate.Hibernate;
54
import org.springframework.beans.factory.annotation.Autowired;
65
import org.springframework.stereotype.Service;
76
import org.springframework.transaction.annotation.Transactional;
87
import wooteco.prolog.member.application.MemberService;
98
import wooteco.prolog.member.domain.Member;
109
import wooteco.prolog.roadmap.application.dto.EssayAnswerRequest;
10+
import wooteco.prolog.roadmap.application.dto.EssayAnswerUpdateRequest;
1111
import wooteco.prolog.roadmap.domain.EssayAnswer;
1212
import wooteco.prolog.roadmap.domain.Quiz;
1313
import wooteco.prolog.roadmap.domain.repository.EssayAnswerRepository;
1414
import wooteco.prolog.roadmap.domain.repository.QuizRepository;
1515

16-
import javax.persistence.PersistenceContext;
16+
import java.util.List;
1717

1818
@Transactional
1919
@Service
@@ -46,11 +46,11 @@ public Long createEssayAnswer(EssayAnswerRequest essayAnswerRequest, Long member
4646
}
4747

4848
@Transactional
49-
public void updateEssayAnswer(Long answerId, String answer, Long memberId) {
49+
public void updateEssayAnswer(Long answerId, EssayAnswerUpdateRequest request, Long memberId) {
5050
EssayAnswer essayAnswer = getById(answerId);
5151
Member member = memberService.findById(memberId);
5252

53-
essayAnswer.update(answer, member);
53+
essayAnswer.update(request.getAnswer(), member);
5454
essayAnswerRepository.save(essayAnswer);
5555
}
5656

backend/src/main/java/wooteco/prolog/roadmap/ui/EssayAnswerController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ public ResponseEntity<EssayAnswerResponse> findById(@PathVariable Long essayAnsw
4949
public ResponseEntity<Void> updateById(@PathVariable Long essayAnswerId,
5050
@AuthMemberPrincipal LoginMember member,
5151
@RequestBody EssayAnswerUpdateRequest request) {
52-
essayAnswerService.updateEssayAnswer(essayAnswerId, request.getAnswer(), member.getId());
52+
essayAnswerService.updateEssayAnswer(essayAnswerId, request, member.getId());
5353
return ResponseEntity.ok().build();
5454
}
55-
55+
5656
@DeleteMapping("/essay-answers/{essayAnswerId}")
5757
public ResponseEntity<Void> deleteEssayAnswerById(@PathVariable Long essayAnswerId,
5858
@AuthMemberPrincipal LoginMember member) {
@@ -61,7 +61,7 @@ public ResponseEntity<Void> deleteEssayAnswerById(@PathVariable Long essayAnswer
6161
}
6262

6363
@GetMapping("/quizzes/{quizId}")
64-
public ResponseEntity<QuizResponse> findEssayAnswerById(@PathVariable Long quizId) {
64+
public ResponseEntity<QuizResponse> findQuizById(@PathVariable Long quizId) {
6565
return ResponseEntity.ok(quizService.findById(quizId));
6666
}
6767

backend/src/test/java/wooteco/prolog/roadmap/application/EssayAnswerServiceTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import wooteco.prolog.member.domain.Member;
1111
import wooteco.prolog.member.exception.MemberNotFoundException;
1212
import wooteco.prolog.roadmap.application.dto.EssayAnswerRequest;
13+
import wooteco.prolog.roadmap.application.dto.EssayAnswerUpdateRequest;
1314
import wooteco.prolog.roadmap.domain.EssayAnswer;
1415
import wooteco.prolog.roadmap.domain.Quiz;
1516
import wooteco.prolog.roadmap.domain.repository.EssayAnswerRepository;
@@ -22,10 +23,7 @@
2223
import static org.assertj.core.api.Assertions.assertThat;
2324
import static org.assertj.core.api.Assertions.assertThatThrownBy;
2425
import static org.mockito.ArgumentMatchers.any;
25-
import static org.mockito.Mockito.anyLong;
26-
import static org.mockito.Mockito.times;
27-
import static org.mockito.Mockito.verify;
28-
import static org.mockito.Mockito.when;
26+
import static org.mockito.Mockito.*;
2927

3028
@ExtendWith(MockitoExtension.class)
3129
class EssayAnswerServiceTest {
@@ -77,7 +75,7 @@ void updateEssayAnswer() {
7775
.thenReturn(new Member(null, null, null, 1L, null));
7876

7977
//when
80-
essayAnswerService.updateEssayAnswer(1L, "answer", 1L);
78+
essayAnswerService.updateEssayAnswer(1L, new EssayAnswerUpdateRequest("answer"), 1L);
8179

8280
//then
8381
verify(essayAnswerRepository, times(1)).save(any());

0 commit comments

Comments
 (0)