Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsarify all tools in the repo #281

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

martenson
Copy link

@martenson martenson commented Jan 2, 2025

pulsar needs to explicitly know about the files included in the command, this PR adds this information to all tools in the repo that are missing it (some already had it)

While having a look a this I also found some minor inconsistencies in requirements and syntax, check the later commits for details.

closes #279

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@martenson martenson requested a review from lecorguille as a code owner January 2, 2025 09:02
Copy link
Contributor

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martenson. Can you maybe come up with a small script to detect those tools. We probably want to add this to more tools.

in a version roughly from the same timeline
slesh is already part of the macro, not sure if this can faiil sometimes, but this commit should be correct always
@martenson
Copy link
Author

@bgruening done

@martenson martenson changed the title readmsdata: add required files for pulsar pulsarify all tools in the repo Jan 8, 2025
Copy link
Contributor

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add required_files to tools/xcms/msnbase_readmsdata.xml
2 participants